Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

feat: use new version pkg #6

Merged
merged 4 commits into from
Oct 23, 2020
Merged

feat: use new version pkg #6

merged 4 commits into from
Oct 23, 2020

Conversation

jbrockopp
Copy link
Contributor

Dependent on go-vela/types#112

Updating to the new go-vela/types/version package to improve the information provided surrounding the application.

When I run make run locally, here is the output:

{
  "canonical": "v0.1.0",
  "major": 0,
  "minor": 1,
  "patch": 0,
  "metadata": {
    "architecture": "amd64",
    "build_date": "2020-10-20T14:52:43Z",
    "compiler": "gc",
    "git_commit": "dd7e4a9d34e019afb58aeda4c2b0ebb7f30d5fe9",
    "go_version": "go1.15.2",
    "operating_system": "linux"
  }
}
<more logs>

NOTE: This also updates the GitHub Actions pipelines to use our make commands for building the binary.

@jbrockopp jbrockopp self-assigned this Oct 20, 2020
@jbrockopp jbrockopp added the feature Indicates a new feature label Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #6 into master will decrease coverage by 1.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   59.29%   58.27%   -1.03%     
==========================================
  Files           6        6              
  Lines         285      290       +5     
==========================================
  Hits          169      169              
- Misses        106      111       +5     
  Partials       10       10              
Impacted Files Coverage Δ
cmd/vela-makisu/main.go 0.00% <0.00%> (ø)

@jbrockopp jbrockopp marked this pull request as ready for review October 20, 2020 20:33
@jbrockopp jbrockopp requested a review from a team as a code owner October 20, 2020 20:33
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit 4155645 into master Oct 23, 2020
@kneal kneal deleted the feat/version branch October 23, 2020 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants