Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license): update source code headers + copyright year #53

Merged
merged 1 commit into from
Oct 11, 2023

chore(license): update source code headers + copyright year

402b39a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore(license): update source code headers + copyright year #53

chore(license): update source code headers + copyright year
402b39a
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Sep 22, 2023 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (6)

cmd/vela-npm/main.go|249 col 2| if-return: redundant if ...; err != nil check, just return error instead. (revive)
internal/npm/plugin.go|63 col 2| if-return: redundant if ...; err != nil check, just return error instead. (revive)
internal/npm/plugin.go|128 col 2| if-return: redundant if ...; err != nil check, just return error instead. (revive)
internal/npm/plugin_test.go|112 col 26| directive // nolint: errcheck // testing should be written without leading space as //nolint: errcheck // testing (nolintlint)
internal/npm/plugin_test.go|144 col 26| directive // nolint: errcheck // testing should be written without leading space as //nolint: errcheck // testing (nolintlint)
internal/npm/plugin_test.go|177 col 26| directive // nolint: errcheck // testing should be written without leading space as //nolint: errcheck // testing (nolintlint)

Filtered Findings (0)

Annotations

Check failure on line 249 in cmd/vela-npm/main.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] cmd/vela-npm/main.go#L249

if-return: redundant if ...; err != nil check, just return error instead. (revive)
Raw output
cmd/vela-npm/main.go:249:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := p.Exec(); err != nil {
		return err
	}

Check failure on line 63 in internal/npm/plugin.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/npm/plugin.go#L63

if-return: redundant if ...; err != nil check, just return error instead. (revive)
Raw output
internal/npm/plugin.go:63:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := p.config.Validate(); err != nil {
		return err
	}

Check failure on line 128 in internal/npm/plugin.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/npm/plugin.go#L128

if-return: redundant if ...; err != nil check, just return error instead. (revive)
Raw output
internal/npm/plugin.go:128:2: if-return: redundant if ...; err != nil check, just return error instead. (revive)
	if err := p.publish(); err != nil {
		return err
	}

Check failure on line 112 in internal/npm/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/npm/plugin_test.go#L112

directive `// nolint: errcheck // testing` should be written without leading space as `//nolint: errcheck // testing` (nolintlint)
Raw output
internal/npm/plugin_test.go:112:26: directive `// nolint: errcheck // testing` should be written without leading space as `//nolint: errcheck // testing` (nolintlint)
	fs.MkdirAll(home, 0755) // nolint: errcheck // testing
	                        ^

Check failure on line 144 in internal/npm/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/npm/plugin_test.go#L144

directive `// nolint: errcheck // testing` should be written without leading space as `//nolint: errcheck // testing` (nolintlint)
Raw output
internal/npm/plugin_test.go:144:26: directive `// nolint: errcheck // testing` should be written without leading space as `//nolint: errcheck // testing` (nolintlint)
	fs.MkdirAll(home, 0755) // nolint: errcheck // testing
	                        ^

Check failure on line 177 in internal/npm/plugin_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] internal/npm/plugin_test.go#L177

directive `// nolint: errcheck // testing` should be written without leading space as `//nolint: errcheck // testing` (nolintlint)
Raw output
internal/npm/plugin_test.go:177:26: directive `// nolint: errcheck // testing` should be written without leading space as `//nolint: errcheck // testing` (nolintlint)
	fs.MkdirAll(home, 0755) // nolint: errcheck // testing
	                        ^