Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing UnimplementedXxxServer from upstream #628

Open
carnott-snap opened this issue Sep 17, 2019 · 2 comments
Open

missing UnimplementedXxxServer from upstream #628

carnott-snap opened this issue Sep 17, 2019 · 2 comments

Comments

@carnott-snap
Copy link

golang/protobuf#875 recently added support for an UnimplementedXxxServer struct, to offer forward compatibility when implementing the generated XxxServer interface[0]. This was released as part of their v1.3.2 release.

I see that #191 tracks upstream merges, per the README.md, but there has been no discussion since December 2019, so I thought I would try and track this separately.

0] See grpc ticket: grpc/grpc-go#2318
@jmarais
Copy link
Contributor

jmarais commented Oct 11, 2019

Hi, Are you referring to this commit:
golang/protobuf@b85cd75
?

@carnott-snap
Copy link
Author

Yes, that should be the change. I think this has been merged in now, but I would need to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmarais @carnott-snap