Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.16: document encoding/json changes for Go 1.16 #42898

Closed
dmitshur opened this issue Nov 30, 2020 · 2 comments
Closed

doc/go1.16: document encoding/json changes for Go 1.16 #42898

dmitshur opened this issue Nov 30, 2020 · 2 comments
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@dmitshur
Copy link
Contributor

As of filing this issue, the Go 1.16 draft release notes contained the following HTML:

encoding/json

The error message for SyntaxError now begins with "json: ", matching the other errors in the package.

TODO: https://golang.org/cl/234818: allow semicolon in field key / struct tag


Per golang.org/s/release, it's a release blocker for Go 1.16 Beta 1 to have a complete draft of the eventual release notes, and so the TODO needs to be resolved.

A sequence of steps to resolve this issue may be:

  1. Come up with a draft release note entry in this issue, then move the issue to NeedsFix state.
  2. Send a CL with "doc/go1.16:" prefix and include "For doc: write Go 1.16 release notes #40700. Fixes #{this issue}." in the body.
@dmitshur dmitshur added Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 30, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Nov 30, 2020
@dsnet
Copy link
Member

dsnet commented Nov 30, 2020

We'll probably roll back this change. See #42675.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/274614 mentions this issue: doc/go1.16: add encoding/json note for tag change

@golang golang locked and limited conversation to collaborators Dec 3, 2021
@rsc rsc unassigned dsnet Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants