Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync/atomic: TestHammer64 failing on linux-mips-rtrk since 2022-05-04 #52723

Closed
bcmills opened this issue May 5, 2022 · 2 comments
Closed

sync/atomic: TestHammer64 failing on linux-mips-rtrk since 2022-05-04 #52723

bcmills opened this issue May 5, 2022 · 2 comments
Labels
arch-mips FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented May 5, 2022

--- FAIL: TestHammer64 (0.02s)
    atomic_test.go:2025: AddUintptrMethod: val=17179869184000 want 4000
FAIL
FAIL	sync/atomic	1.656s

greplogs -l -e 'FAIL: TestHammer64' --since=2022-01-01
2022-05-05T04:53:27-0e90ba9/linux-mips-rtrk
2022-05-05T04:05:43-d544591/linux-mips-rtrk
2022-05-05T01:33:11-0bd7408/linux-mips-rtrk
2022-05-05T01:33:01-ed462a6/linux-mips-rtrk
2022-05-04T21:35:22-aeb933d/linux-mips-rtrk
2022-05-04T18:54:31-037b209/linux-mips-rtrk

The builder is still catching up, but CL 381317 looks like a likely culprit.

(attn @rsc @golang/mips @bogojevic @milanknezevic)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-mips labels May 5, 2022
@bcmills bcmills added this to the Go1.19 milestone May 5, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 5, 2022

Marking as release-blocker since this is a test regression during the current cycle.

Since linux/mips is not a first-class port, this can be resolved by either fixing the failing test or skipping it on the affected platform.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/404495 mentions this issue: sync/atomic: don't run 64-bit uintptr tests on 32-bit systems

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-mips FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants