Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: TestMremapPtr fails with "MremapPtr: cannot allocate memory" on GOOS=netbsd #68180

Closed
dmitshur opened this issue Jun 25, 2024 · 6 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@dmitshur
Copy link
Contributor

This functionality and test was recently added in CL 592415. It fails on GOOS=netbsd specifically:

=== RUN   TestMremapPtr
    mremap_test.go:67: MremapPtr: cannot allocate memory
--- FAIL: TestMremapPtr (0.00s)

(From https://ci.chromium.org/b/8744162608784922945.)

CC @golang/netbsd, @ncruces.

@dmitshur dmitshur added OS-NetBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 25, 2024
@dmitshur dmitshur added this to the Unreleased milestone Jun 25, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 25, 2024
@ncruces
Copy link
Contributor

ncruces commented Jun 25, 2024

Oh. Sorry about that. I had asked to run CI tests because I couldn't test other OSes. I'll try to set up something NetBSD to test this.

@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@ncruces
Copy link
Contributor

ncruces commented Jun 26, 2024

I've tried to verify this fix by setting up NetBSD with GitHub actions, but would appreciate that the CL would go through this testing somehow during review?

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/594756 mentions this issue: unix: fix MremapPtr test failing on NetBSD

@dmitshur
Copy link
Contributor Author

@ncruces See https://go.dev/wiki/SlowBots. In particular, you should be able to include a footer like this:

Cq-Include-Trybots: luci.golang.try:x_sys-gotip-netbsd-arm64

That'll cause those builders to run when a Commit-Queue+1 vote is left.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 26, 2024
@ncruces
Copy link
Contributor

ncruces commented Jun 26, 2024

Apparently there was a CI availability issue. If anyone can try again. Otherwise I'm reasonably confident due to reproducing and fixing on my end. I'll have a stab at #68181.

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants