-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle compatibility issues with v1.4? #1126
Comments
There shouldn't be a need to regenerate existing The
|
I tried to update The panic triggered by
The thing is there are a bunch of Involve @liggitt here too, there is a huge effort to regenerate existing |
There's the problem. The protobuf/proto/table_marshal.go Lines 2679 to 2682 in 8466869
We're technically under no obligation to address this regression, but to ease migration, #1129 adds minimal functionally back to |
Yes it works! And I answered here too. I'm looking forward to new release now. |
v1.4.2 is released. |
The struct type
InternalMessageInfo
has been deprecated bygitpro.ttaallkk.top/golang/protobuf@v1.4.0
:protobuf/proto/deprecated.go
Lines 85 to 92 in 00998c7
But there are a whole bunch of modules still using
*.pb.go
file which contains a reference ofInternalMessageInfo
, such asKubernetes wants to involve a new module version which depends on
github.com/golang/protobuf@v1.4.0
, but this work has been blocked as several modules in Kubernetes' vendor still referringInternalMessageInfo
, more details please refer to kubernetes/kubernetes#90582 (comment).Does it's the right approach to update all those modules by re-compile
*.proto
?If yes, there are two
protoc-gen-go
, one and two, which one should I choose? and should I use the latest version?@dsnet I will be appreciate if you can give some guidence.
The text was updated successfully, but these errors were encountered: