From 45e09b8fb51c73d8d537401e7e4627fddc77c123 Mon Sep 17 00:00:00 2001 From: Daniel Gonzalez Date: Tue, 14 Dec 2021 01:12:05 +0100 Subject: [PATCH] fix: ensure to use correct pointer in home loop When dereferencing loop variables in go, one must ensure to copy the value in the loop variable before dereferencing. Else one dereferences the loop pointer instead of the variable. See [1] for more details. [1]: https://stackoverflow.com/questions/45967305/copying-the-address-of-a-loop-variable-in-go --- window-close.go | 1 + 1 file changed, 1 insertion(+) diff --git a/window-close.go b/window-close.go index 85446b0..ad7223c 100644 --- a/window-close.go +++ b/window-close.go @@ -116,6 +116,7 @@ func CloseWindow(w http.ResponseWriter, r *http.Request) { var userHome *gotado.UserHome for _, h := range user.Homes { if h.Name == action.HomeName { + h := h userHome = &h break }