Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Cluster example fails without msgspec on OS X #269

Open
trifle opened this issue Dec 7, 2021 · 5 comments
Open

Readme: Cluster example fails without msgspec on OS X #269

trifle opened this issue Dec 7, 2021 · 5 comments
Labels
bug Something isn't working examples

Comments

@trifle
Copy link

trifle commented Dec 7, 2021

Hi, as someone who's been looking for a clean async actor-like approach in python, tractor looks amazing!

I just started looking at the docs and code, but noticed the actor cluster / process pool example in the readme fails when tractor is installed via poetry. This is on a M1 mac, python 3.9.9 from homebrew, tractor installed from git via poetry.

Poetry complains about a malformed dependency declaration for msgspec. There is a single quote that's not quite right, but removing it doesn't seem to be the issue.

Resolving dependencies... (1.2s)PackageInfo: Invalid constraint (msgspec >= 0.3.2'; python_version >= '3.9' ; extra == "msgspec") found in tractor-0.1.0a3 dependencies, skipping

@goodboy goodboy added bug Something isn't working examples labels Dec 7, 2021
@goodboy
Copy link
Owner

goodboy commented Dec 7, 2021

Hey @trifle thanks for the report 😎

tractor looks amazing!

Thanks friend. It's been a WIP for some time but I think we're getting close to prime time finally 😂

the actor cluster / process pool example in the readme fails when tractor is installed via poetry.

Poetry complains about a malformed dependency declaration for msgspec. There is a single quote that's not quite right, but removing it doesn't seem to be the issue.

Never tried an install via poetry so not sure what that entails but also we don't have OS X support yet afaik. I'm not totally after using poetry (or one of the other dep management juggernaut tools) any time soon since pip for a library style project seems to be working.

This is on a M1 mac, python 3.9.9 from homebrew, tractor installed from git via poetry.

There's a PR up to get CI going #228 #255 but it's hanging iirc. I think @guilledk mentioned in chat that an app built on tractor worked on a mac they tried but I have no access to one myself.

If you'd like to help work through getting this example and the test suite going it'd sure be chido 🏄🏼

Let us know!

@trifle
Copy link
Author

trifle commented Dec 7, 2021

Hey @goodboy,

thanks for the awesome reply! I'll try to set aside some time to see how it runs on mac and report back, but that's probably going to have to wait until around christmas.

My overall experience with mac multiprocessing, python, executors etc. has been relatively solid, nothing particular I'd fear about being very broken.

As for poetry, I guess it's becoming more popular and seems slightly less cumbersome than all the other package managers I've tried. It seems to follow the PEPs pretty strictly for parsing setup.py. But it might also have a separate dependency resolver from the new-generation pip? I'll try and see if I can find out anything.

@goodboy
Copy link
Owner

goodboy commented Dec 7, 2021

@trifle feel free to jump in our chat on matrix/gitter if you'd like as well.

It might be handy to have some interaction if you do end up working through trying to get OS X support going 😄

It seems to follow the PEPs pretty strictly for parsing setup.py.

I've got no quiffs trying out new stuff if that's where the tide is flowing and honestly I've never seen anything of issue with poetry (it was i think the other one that gave me headaches on a larger project).

My overall experience with mac multiprocessing, python, executors etc. has been relatively solid, nothing particular I'd fear about being very broken.

Cool, yeah and if there's alt spawning backends to be tried on OS X we're all for it as well. That's kind of the point of this design 😏

Cheers and hope to hear from you on this front!

@goodboy
Copy link
Owner

goodboy commented Dec 7, 2021

@overclockworked64 oh, pinging you since I think this was from your PR.

Also, @trifle I'm going to change the title to be OS X specific because I'm pretty sure this example does to work on msgpack (not msgspec) otherwise both our cluster test and the docs example test subset would be failing.

@goodboy goodboy changed the title Readme: Cluster example fails without msgspec Readme: Cluster example fails without msgspec on OS X Dec 7, 2021
@trifle
Copy link
Author

trifle commented Dec 7, 2021

Sure, makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working examples
Projects
None yet
Development

No branches or pull requests

2 participants