Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable stream termination can be solved by tracking streams per portal, per nursery? #87

Open
goodboy opened this issue Oct 22, 2019 · 1 comment
Labels
discussion enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Milestone

Comments

@goodboy
Copy link
Owner

goodboy commented Oct 22, 2019

As per #57 we need a system to help manage stream teardown, namely the explicit calling of StreamReceiveChannel.aclose() on either intentional stream termination by a consumer/producer or by the containing ActorNursery during its wait on all actors to complete or error phase.

what we've got right now:

That last suggestion needs some thought; task-actor interaction in terms of how portals can be passed around between task versus actor nurseries is not clear to me yet.

@goodboy goodboy added discussion enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Oct 22, 2019
@goodboy goodboy added this to the 0.1.0.a0 milestone Oct 22, 2019
@goodboy
Copy link
Owner Author

goodboy commented Oct 23, 2019

Actually hold up, if a push producer (using Context) exits its decorated function the client should be signalled that the stream stopped - which results in the local results channel being closed and thus subsequently in the IPC channel being cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant