Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statics with download of Recursive from Google Fonts work poorly on Windows, macOS, Adobe apps, and probably more #2616

Open
arrowtype opened this issue Aug 12, 2020 · 16 comments

Comments

@arrowtype
Copy link
Collaborator

arrowtype commented Aug 12, 2020

The static fonts for Recursive that are available via the "Download Family" function of the Recursive specimen on Google Fonts have several issues that make them very unuseful in most contexts.

This is a particular problem because many designers would be likely to use static fonts to design a website or app before then using Google Fonts to provide the fonts on the web. And, many popular design tools currently work best with static fonts – exporting variable fonts to PDFs is flaky, and variable fonts aren’t yet supported at all in Figma.

Until this can be resolved, I propose that we replace the current, auto-generated fonts with the statics available from the official Recursive releases. I know this approach may not work for every family, but the Recursive statics have been specifically engineered by Ben Kiel, a type engineer with years of experience, so it would be worth making an exception to use the higher-quality fonts until the auto-generated instances can perform as well.

Issues include

Filenames

Filenames are confusing. They should do something to include the instance names, such as RecursiveMonoCslSt-BlkItalic.otf (an abbreviated form used in the Recursive releases – possibly, it would be even better with less abbreviation). Instead, the downloads from Google Fonts specify the weight first, then axis values, which are hard to understand without a fairly deep knowledge of the font, such as Recursive-Black-CASL=0-CRSV=1-MONO=0-slnt=0.ttf.

image

Font style sorting & availability

  • The font metadata only uses weight descriptors in style names, which disrupts macOS Font Book, as well as font menus in many or all apps. In Font Book, styles are marked as duplicates, and "Resolve Automatically" deletes all but one of each weight.

image

  • In Adobe apps, this style naming results in just seven available styles, which aren’t even in a consistent subfamily, making them totally confusing and more or less impossible to use together.

styes available in adobe

Kapture 2020-08-12 at 0 15 49

  • There are also problems in other apps. In Sketch, for example, the menu appears to show a bunch of "Regular" styles all selected at the same time:

image

  • In Figma, the issue is similar to Adobe apps, though it is a different arbitrary seven styles that are available.

image

  • This is perhaps even worse on Windows, where the repeated names make it impossible to install all of the static instances at the same time. (Then again, even though Mac allows all instances to be installed, only a few are actually selectable, so it’s a tossup of what’s worse.)

image

General disruption of design intent

  • Weight is used as the principle/only sorting category. Not only does that cause practical issues of file handling & text layout, but it also isn’t a very useful way to break down this family. Instead, it is much simpler to think of as four sub-families (Sans Casual, Sans Linear, Mono Casual, & Mono Linear), each with a range of weight & italics. Here’s a table of the instances designed for the font, illustrating the intended subfamilies:

image

Incorrect & Limited styles

  • The GF download statics exclude any slanted styles.
  • Half the fonts are upright but have "CRSV" at 1, making them upright italics. These work okay as fonts, but I don’t think they are the most useful part of the family. They look maybe a little more frilly than I think tends to be useful.
  • The fonts exclude ExtraBlack styles at wght=1000

Solutions

  • It seems that these static instances must have been generated based on a combination of available values in each axis. Instead, these styles should be generated from the preset instances listed in the fvar table.
  • For this family, we already have thoughtfully-produced static fonts that will very likely work better and in more places than static fonts instantiated from the variable font. So, we should probably include these in the download.

I know it takes a lot to make a service as complex as Google Fonts, and I know things like this are inevitable. But, I’m hoping it can be resolved relatively quickly, as the main solution is pretty simple. Let me know if you need any further info. Thanks!

@arrowtype
Copy link
Collaborator Author

It may be helpful to show specific TTX diffs of fonts. Not all the styles are the same, but some are. So, using fdiff, here are the most important diffs between the official statics & the Google Fonts generated statics, comparing

  • RecursiveSansLnrSt-Black.ttf ("before", red lines)
  • Recursive-Black-CASL=0-CRSV=0-MONO=0-slnt=0.ttf ("after", green lines)

I have reduced the diff to focus on the only the tables which I believe are likely to cause problems for users, and placed these into detail dropdowns to hopefully keep this issue readable.

This excludes hinting, which the official statics have but the generated statics lack. It is a lot of data which makes it sensible to exclude in webfonts and from this diff, but that shouldn’t really matter to desktop font users.

OS/2 table

OS/2 (Click to expand)
--- /Users/stephennixon/type-repos/recursive/fonts/Recursive-1.054/Recursive_Desktop/separate_OTF_TTF_statics/Static_TTF/RecursiveSansLnrSt-Black.ttf	2020-08-07T21:43:31.476375-04:00
+++ /Users/stephennixon/Library/Fonts/Recursive-google_fonts_download-2020_08_07/static/Recursive-Black-CASL=0-CRSV=0-MONO=0-slnt=0.ttf	2019-06-28T16:24:56-04:00
@@ -5,7 +5,7 @@
     <!-- The fields 'usFirstCharIndex' and 'usLastCharIndex'
          will be recalculated by the compiler -->
     <version value="4"/>
-    <xAvgCharWidth value="612"/>
+    <xAvgCharWidth value="611"/>
     <usWeightClass value="900"/>
     <usWidthClass value="5"/>
     <fsType value="00000000 00000000"/>
@@ -18,34 +18,34 @@
     <ySuperscriptXOffset value="0"/>
     <ySuperscriptYOffset value="350"/>
     <yStrikeoutSize value="45"/>
-    <yStrikeoutPosition value="328"/>
+    <yStrikeoutPosition value="282"/>
     <sFamilyClass value="0"/>
     <panose>
-      <bFamilyType value="2"/>
-      <bSerifStyle value="11"/>
-      <bWeight value="10"/>
-      <bProportion value="4"/>
-      <bContrast value="4"/>
-      <bStrokeVariation value="2"/>
-      <bArmStyle value="2"/>
-      <bLetterForm value="4"/>
-      <bMidline value="2"/>
-      <bXHeight value="4"/>
+      <bFamilyType value="0"/>
+      <bSerifStyle value="0"/>
+      <bWeight value="0"/>
+      <bProportion value="0"/>
+      <bContrast value="0"/>
+      <bStrokeVariation value="0"/>
+      <bArmStyle value="0"/>
+      <bLetterForm value="0"/>
+      <bMidline value="0"/>
+      <bXHeight value="0"/>
     </panose>
-    <ulUnicodeRange1 value="00100000 00000000 00000000 00000111"/>
-    <ulUnicodeRange2 value="00010000 00000000 00000000 00000011"/>
+    <ulUnicodeRange1 value="10100001 00000000 00000000 11111111"/>
+    <ulUnicodeRange2 value="01010000 00000000 11100000 01111011"/>
     <ulUnicodeRange3 value="00000000 00000000 00000000 00000000"/>
     <ulUnicodeRange4 value="00000000 00000000 00000000 00000000"/>
     <achVendID value="ARRW"/>
-    <fsSelection value="00000001 10000000"/>
+    <fsSelection value="00000000 11000000"/>
     <usFirstCharIndex value="13"/>
-    <usLastCharIndex value="64258"/>
+    <usLastCharIndex value="64260"/>
     <sTypoAscender value="950"/>
     <sTypoDescender value="-250"/>
     <sTypoLineGap value="0"/>
     <usWinAscent value="1207"/>
     <usWinDescent value="271"/>
-    <ulCodePageRange1 value="00100000 00000000 00000001 10010011"/>
+    <ulCodePageRange1 value="01100000 00000000 00000001 10010011"/>
     <ulCodePageRange2 value="00000000 00000000 00000000 00000000"/>
     <sxHeight value="547"/>
     <sCapHeight value="700"/>

Significant known diff issues:

  • Panose values have been flattened to all zeros
  • fsSelection is different – most notably, bit 6 is set, incorrectly indicating that this Black style is the "Regular" of the family. Likely, this is set in all generated statics, which will be disruptive for Windows users. Bit 8 also gets unset, indicating that this isn’t a WWS family, though I don’t have firsthand understanding of the effects of that difference.

Name table

name (Click to expand)
--- /Users/stephennixon/type-repos/recursive/fonts/Recursive-1.054/Recursive_Desktop/separate_OTF_TTF_statics/Static_TTF/RecursiveSansLnrSt-Black.ttf	2020-08-07T21:43:31.476375-04:00
+++ /Users/stephennixon/Library/Fonts/Recursive-google_fonts_download-2020_08_07/static/Recursive-Black-CASL=0-CRSV=0-MONO=0-slnt=0.ttf	2019-06-28T16:24:56-04:00
@@ -2,92 +2,32 @@
 <ttFont sfntVersion="\x00\x01\x00\x00" ttLibVersion="4.13">
 
   <name>
-    <namerecord nameID="0" platformID="1" platEncID="0" langID="0x0" unicode="True">
+    <namerecord nameID="0" platformID="3" platEncID="1" langID="0x409">
       Copyright 2019 The Recursive Project Authors (github.com/arrowtype/recursive)
     </namerecord>
-    <namerecord nameID="1" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Recursive Sn Lnr St Blk
-    </namerecord>
-    <namerecord nameID="2" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Regular
-    </namerecord>
-    <namerecord nameID="3" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      1.054;ARRW;RecursiveSansLnrSt-Black
-    </namerecord>
-    <namerecord nameID="4" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Recursive Sn Lnr St Blk
-    </namerecord>
-    <namerecord nameID="5" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Version 1.054;hotconv 1.0.112;makeotfexe 2.5.65598; ttfautohint (v1.8.3)
-    </namerecord>
-    <namerecord nameID="6" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      RecursiveSansLnrSt-Black
-    </namerecord>
-    <namerecord nameID="13" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL
-    </namerecord>
-    <namerecord nameID="256" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Single-story ‘a’
-    </namerecord>
-    <namerecord nameID="257" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Single-story ‘g’
-    </namerecord>
-    <namerecord nameID="258" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Simplified Mono ‘f’
-    </namerecord>
-    <namerecord nameID="259" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Simplified Mono ‘i’
-    </namerecord>
-    <namerecord nameID="260" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Simplified Mono ‘l’
-    </namerecord>
-    <namerecord nameID="261" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Simplified Mono ‘r’
-    </namerecord>
-    <namerecord nameID="262" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      No-serif  18L 19 &amp; ‘Z’
-    </namerecord>
-    <namerecord nameID="263" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Simplified Mono ‘at’
-    </namerecord>
-    <namerecord nameID="264" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Simplified Six &amp; Nine
-    </namerecord>
-    <namerecord nameID="265" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Dotted Zero
-    </namerecord>
-    <namerecord nameID="266" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Simplified One
-    </namerecord>
-    <namerecord nameID="267" platformID="1" platEncID="0" langID="0x0" unicode="True">
-      Slashed Zero in Sans
-    </namerecord>
-    <namerecord nameID="0" platformID="3" platEncID="1" langID="0x409">
-      Copyright 2019 The Recursive Project Authors (github.com/arrowtype/recursive).
-    </namerecord>
     <namerecord nameID="1" platformID="3" platEncID="1" langID="0x409">
-      Recursive Sn Lnr St Blk
+      Recursive Black
     </namerecord>
     <namerecord nameID="2" platformID="3" platEncID="1" langID="0x409">
       Regular
     </namerecord>
     <namerecord nameID="3" platformID="3" platEncID="1" langID="0x409">
-      1.054;ARRW;RecursiveSansLnrSt-Black
+      1.047;ARRW;Recursive-Black
     </namerecord>
     <namerecord nameID="4" platformID="3" platEncID="1" langID="0x409">
-      Recursive Sn Lnr St Blk
+      Recursive Black
     </namerecord>
     <namerecord nameID="5" platformID="3" platEncID="1" langID="0x409">
-      Version 1.054;hotconv 1.0.112;makeotfexe 2.5.65598; ttfautohint (v1.8.3)
+      Version 1.047
     </namerecord>
     <namerecord nameID="6" platformID="3" platEncID="1" langID="0x409">
-      RecursiveSansLnrSt-Black
+      Recursive-Black
     </namerecord>
     <namerecord nameID="13" platformID="3" platEncID="1" langID="0x409">
       This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL
     </namerecord>
     <namerecord nameID="16" platformID="3" platEncID="1" langID="0x409">
-      Recursive Sans Linear Static
+      Recursive
     </namerecord>
     <namerecord nameID="17" platformID="3" platEncID="1" langID="0x409">
       Black
@@ -123,10 +63,34 @@
       Dotted Zero
     </namerecord>
     <namerecord nameID="266" platformID="3" platEncID="1" langID="0x409">
+      Slashed Zero in Sans
+    </namerecord>
+    <namerecord nameID="267" platformID="3" platEncID="1" langID="0x409">
       Simplified One
     </namerecord>
-    <namerecord nameID="267" platformID="3" platEncID="1" langID="0x409">
-      Slashed Zero in Sans
+    <namerecord nameID="268" platformID="3" platEncID="1" langID="0x409">
+      Monospace
+    </namerecord>
+    <namerecord nameID="269" platformID="3" platEncID="1" langID="0x409">
+      Casual
+    </namerecord>
+    <namerecord nameID="270" platformID="3" platEncID="1" langID="0x409">
+      Weight
+    </namerecord>
+    <namerecord nameID="271" platformID="3" platEncID="1" langID="0x409">
+      Slant
+    </namerecord>
+    <namerecord nameID="272" platformID="3" platEncID="1" langID="0x409">
+      Cursive
+    </namerecord>
+    <namerecord nameID="401" platformID="3" platEncID="1" langID="0x409">
+      Sans
+    </namerecord>
+    <namerecord nameID="403" platformID="3" platEncID="1" langID="0x409">
+      Linear
+    </namerecord>
+    <namerecord nameID="411" platformID="3" platEncID="1" langID="0x409">
+      Black
     </namerecord>
   </name>

Significant known issues:

  • Differences in Names 1, 3, 4, 6, 16, & 17 are causing the biggest problems, as name tables are flattened to only handle weight, causing clashes between many of the instances as shown in the original comment of this thread

Head table

head (Click to expand)
--- /Users/stephennixon/type-repos/recursive/fonts/Recursive-1.054/Recursive_Desktop/separate_OTF_TTF_statics/Static_TTF/RecursiveSansLnrSt-Black.ttf	2020-08-07T21:43:31.476375-04:00
+++ /Users/stephennixon/Library/Fonts/Recursive-google_fonts_download-2020_08_07/static/Recursive-Black-CASL=0-CRSV=0-MONO=0-slnt=0.ttf	2019-06-28T16:24:56-04:00
@@ -4,21 +4,21 @@
   <head>
     <!-- Most of this table will be recalculated by the compiler -->
     <tableVersion value="1.0"/>
-    <fontRevision value="1.054"/>
-    <checkSumAdjustment value="0x431a8cea"/>
+    <fontRevision value="1.047"/>
+    <checkSumAdjustment value="0x5989d04"/>
     <magicNumber value="0x5f0f3cf5"/>
-    <flags value="00000000 00000101"/>
+    <flags value="00000000 00000011"/>
     <unitsPerEm value="1000"/>
-    <created value="Sat May 16 23:10:37 2020"/>
-    <modified value="Tue Aug  4 23:12:36 2020"/>
-    <xMin value="-346"/>
-    <yMin value="-435"/>
-    <xMax value="2373"/>
-    <yMax value="1156"/>
+    <created value="Sat Apr  4 15:39:24 2020"/>
+    <modified value="Sat Apr  4 15:40:17 2020"/>
+    <xMin value="-228"/>
+    <yMin value="-363"/>
+    <xMax value="2380"/>
+    <yMax value="1125"/>
     <macStyle value="00000000 00000000"/>
     <lowestRecPPEM value="6"/>
     <fontDirectionHint value="2"/>
-    <indexToLocFormat value="1"/>
+    <indexToLocFormat value="0"/>
     <glyphDataFormat value="0"/>
   </head>

Possibly significant diffs:

  • flags changed
  • modified box values xMin yMin xMax yMax
  • indexToLocFormat changed

STAT table

The generated instance keep the STAT table from the variable font, which I previously found to cause issues for static fonts on Windows in VS Code

Other diffs

  • There are also a lot of diffs in the GSUB table, but happily, the OpenType stylistic set features & discretionary ligatures are preserved in the generated instances.

image

There may be other important diffs that I am unaware of, but these are things I know or suspect to cause problems.

@thlinard
Copy link
Contributor

Hi Stephen, thanks for this extensive study! I don't give my teams fonts from https://fonts.google.com/, I take them directly here, and with good reason I think.

STAT table

The generated instance keep the STAT table from the variable font, which I previously found to cause issues for static fonts on Windows in VS Code

The presence of a STAT table also poses problems for MS Office for Mac. https://github.com/clauseggers/Playfair-Display/issues/24, for example.

@davelab6
Copy link
Member

davelab6 commented Aug 12, 2020 via email

@arrowtype arrowtype changed the title Statics with download of Recursive from Google Fonts works poorly on macOS & in Adobe apps Statics with download of Recursive from Google Fonts work poorly on Windows, macOS, Adobe apps, and probably more Aug 14, 2020
@anthrotype
Copy link
Member

To explain the differences highlithed above by @thundernixon between the official static fonts & the Google Fonts generated static fonts, one needs to understand how each set is generated by fontmake.

The static fonts are interpolated at the source UFO level: i.e. instance UFOs are first generated from the master UFOs + .designspace (by fontmake.instantiator). Then, instance-specific metadata like the ones defined in Glyphs.app custom parameters (e.g., panose, unicode ranges, OS/2 useTypoMetrics, etc.) are applied to each instance UFOs, and finally the UFOs are converted to TTF, with their own distinct OS/2, name, head, etc. tables.

The Google Fonts generated static fonts as included in the downloadable .zip files are instantiated from the variable font built from the same set of master UFOs and .designspace used earlier to generate the static fonts. In the VF build process we first generate a set of master TTFs (one per master UFO) with interpolatable outlines (i.e. no overlaps removed), then use fontTools.varLib with these master TTFs and the same .designspace source to compute the deltas and store them in the variation tables. The new VF starts out as a copy of the default or neutral master TTF plus the the new variation tables added to it. Now, among the tables that don't change in a VF and are simply copied from the default master are OS/2, head and name table.

Finally, when the GF instances are generated from a VF (using fontTools.varLib.instancer module), the deltas from each variation tables are computed and applied to the default tables, and the variation tables removed; however, all the non-variable metadata stay as it was in the VF, i.e. same as was the default master TTF.
Also note that the fonttools instancer currently only sets the OS/2 weight/width class and and post.italicAngle from wght, wdth and slnt respectively, but does not modify the style-linking flags in head and OS/2 (fonttools/fonttools#1264), nor modifies the name table (fonttools/fonttools#1704).
For that at GF we internally run some other touch-ups to the thus generated instances: namely we set OS/2 fsSelection and head.macStyle bold bit if wght=700, and enable the italic bit if the instance's ital axis position is 1.0. We also run a tool called fix_name_table that given the family name and the axis position of an instance, it uses our Axis Registry where metadata for each axis in our API is defined to update the instance style names. At the moment that tool only supports wght, wdth and ital axes, and ignores other axes (which is why Recursive style names appear incorrect and duplicated), but we are working on fixing that.

With that background, I'll now try to comment on each tables' diffs individually. I already touched upon a current limitation in our tooling that explain the differences in the name table.

OS / 2

  • the panose values you see in the GF statics is the one from the default master TTF, copied to the VF and from there to all the generated instances. Note I said "master", not the "instance" that is at the same location as the default master (usually called Regular). In the official static fonts the panose values are individually set on each instance. In Glyphs.app these values are usually set in the Instances panel as custom parameters, which are only applied in the static build pipeline, not the VF one.
    The master TTF used to build the VF does not get these values, hence why you see them all zeros. Even if you could set these different panose values on the individual masters (I'm not sure you can), there wouldn't be a place to store them in the VF. Panose simply does not vary (unlike other font-wide metadata defined in MVAR table). I don't know how relevant Panose is nowadays, but if we really cared to support it in the VF-generated instances, we would need to apply some sort of post-processing (same like we do for name table).

  • same thing for unicode ranges, they are those from the master TTF, instead of the instances. I believe Glyphs.app should let you set these at a fond-wide level (in the Font tab) so that they apply to all masters and instances. Unless the cmap coverage changes between instances (which I don't think it's the case here).

  • About fsSelection, Stephen spotted an actual bug there: the bit 6 flag ("Regular") which should only be set once in a family, is kept for all our generated instances. This is also probably inherited from the VF, and in turn, from the default master (usually but not always a "Regular"). An exception is the wght=700 instance, because I see that in our fix_name_table.py internal script we explicitly un-set the bit 6 when we set the "Bold" bit. Apparently we forgot to also unset the bit 6 for all the non-Regular, non-Bold and non-Italic instances.

Bit 8 also gets unset, indicating that this isn’t a WWS family

Again if we want the VF and thus the instances generated from it to be flagged as WWS, we need to make sure the default master from which the VF is generated to be flagged as such. I suspect that in Recursive only the invidual instances have the corresponding custom parameter for WWS in the .glyphs source. We should try to copy that parameter to the font panel so that it affects all the masters/instances. Note that even if inside Glyhps.app a custom parameter appears as greyed out (to indicate that it is unsupported for the current font/master/instance panel), fontmake (via glyphsLib) will happily apply it nonetheless.

head

modified box values xMin yMin xMax yMax
indexToLocFormat changed

this is computed automatically, you can ignore

flags

the bit 1 (the second starting from the right) is always recomputed by fonttools. It should be correct in the generated instance.
Not sure about the bit 2 (third from the right) "Instructions may depend on point size", what tool set that and how. Probably again something that is set by some custom parameter and inherited along by master TTF => VF => generated instance.

STAT

The fontTools instancer keeps the VF's STAT table DesignAxes, and prunes AxisValues that are out of range and keep only those that are at the same position as the instance. Initially the instancer (formerly known as mutator) was dropping the STAT table as a whole for full static instances, but we changed it to keep the original STAT design axes as the table is supposed to be a superset of fvar and describes relations between members of a family, variable and not, see fonttools/fonttools#2049 (comment)
It would be interesting to investigate why the STAT table as pruned by the fonttools instancer in the GF generated instances was producing the issues reported in arrowtype/recursive#336. Dropping STAT from the GF generated instances could be a temporary solution until we understand why that's the case.

@davelab6
Copy link
Member

davelab6 commented Sep 21, 2020

A user wrote in,

Hi I recently downloaded Crimson font family for my work as I recently got a new laptop. As I go to use the fonts in programs such as microsoft word or acrobat adobe and only "Crimson Text" and "Crimson Text SemiBold" appear while I believe there should be 6 fonts in the font list. Can you assist in explaining why this might be? On my previous laptop, all 6 fonts were listed in the program font lists

I guess this is related to this issue.

@davelab6
Copy link
Member

davelab6 commented Oct 8, 2020

Related issues:

#2702

googlefonts/gf-docs#83

@davelab6
Copy link
Member

davelab6 commented Oct 8, 2020

@RosaWagner I've send you some private fonts to preview how the GF API engineering team are planning to resolve this, please take a look and post any suggestions about how they should be different, and I will do the same :)

@arrowtype
Copy link
Collaborator Author

I’ve noticed that Inter statics in the Salma ZIPs are missing Italic fonts, even though the variable font includes both wght & slnt axes.

This is probably due to Inter lacking a proper STAT table.

image

image

Current STAT table of Inter (lacks entries for weight locations and for Roman/Italic locations:

  <STAT>
    <Version value="0x00010001"/>
    <DesignAxisRecordSize value="8"/>
    <!-- DesignAxisCount=2 -->
    <DesignAxisRecord>
      <Axis index="0">
        <AxisTag value="wght"/>
        <AxisNameID value="270"/>  <!-- Weight -->
        <AxisOrdering value="0"/>
      </Axis>
      <Axis index="1">
        <AxisTag value="slnt"/>
        <AxisNameID value="271"/>  <!-- Slant -->
        <AxisOrdering value="1"/>
      </Axis>
    </DesignAxisRecord>
    <!-- AxisValueCount=0 -->
    <ElidedFallbackNameID value="2"/>  <!-- Regular -->
  </STAT>

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 19, 2020

Just took a look at Salma's output.

The font nametable's LGTM. They use the typo family name and typo subfamilyname correctly.

My only criticism is the filenames. They currently include the axis tags e.g Recursive~CRSV_Cursive-SemiBold.ttf, Cabin~wdth_SemiCondensed-Bold.ttf. I prefer them without, Recursive-CursiveSemiBold.ttf, Cabin-SemiCondensedBold.ttf.

@RosaWagner also pointed out that nameID 25 may be redundant.

I'm wondering if this update can handle multilingual nameRecords?

@davelab6
Copy link
Member

The font nametable's LGTM

My only criticism is the filenames. They currently include the axis tags

In this case, if the same style name is used in 3 axes, and only 2 are used, which 2 are used will be ambiguous, and the 3 different pairs will all look the same.

@RosaWagner also pointed out that nameID 25 may be redundant.

Yes, that isn't needed in statics.

I'm wondering if this update can handle multilingual nameRecords?

These should be stripped or handled the same way. We haven't got fontbakery checks for those, so if they are included, its by the grace of the upstream, and so probably dropping them and filing a tech debt issue to go back in and fix them all up across the library would be good.

@davelab6
Copy link
Member

This should now be fixed, please comment if not

@thlinard
Copy link
Contributor

This should now be fixed, please comment if not

Hi @davelab6

I downloaded Inter on https://fonts.google.com/specimen/Inter today and I tested it in Microsoft Word 365 for Mac, version 16.46 (February 2021 update).

First test:
Inter

The fonts have panose.bWeight wrong (all at 5, corresponding to the "Book" weight), and fsSelection bit 6 is enabled for all weights except Bold (bit 6 = Regular weight, so only Bold and Regular have a correct fsSelection).

The fonts have a dummy STAT table too.

In a comment above, @anthrotype wrote:

About fsSelection, Stephen spotted an actual bug there: the bit 6 flag ("Regular") which should only be set once in a family, is kept for all our generated instances. This is also probably inherited from the VF, and in turn, from the default master (usually but not always a "Regular"). An exception is the wght=700 instance, because I see that in our fix_name_table.py internal script we explicitly un-set the bit 6 when we set the "Bold" bit. Apparently we forgot to also unset the bit 6 for all the non-Regular, non-Bold and non-Italic instances.

Yep. Still forgotten.

Second test, with panose.bWeight and fsSelection corrected:
Inter OS2 corrected

Third test, with panose.bWeight and fsSelection corrected, and STAT table removed:
Inter OS2 corrected + STAT removed

Like I said in my August 2020 comment, the mere presence of a STAT table causes problems for MS Office for Mac (although the February 2021 update has improved compatibility with VFs, Word remains very demanding on the relationship between the STAT table and the fvar table, which doesn't apply here: no fvar table). Remove the dummy STAT table: problems gone.

I should point out that before each of my tests with a new version of the fonts, I emptied the contents of the following folders:

  1. ~/Library/Containers/com.microsoft.Word/Data/Library/Application Support/Microsoft/FontCache
  2. ~/Library/Containers/com.microsoft.Word/Data/Library/Application Support/Microsoft/FontPreviewCache

@anthrotype
Copy link
Member

@davelab6 please reopen this (I somehow can't)

I don't think panose is relevant here, but incorrect fsSelection and incomplete STAT definitely are. We need to investigate whether our internal tools are doing the right thing.
fsSelection bit 6 (Regular) should only be set once within each group of "R/I/B/BI" fonts sharing the same legacy familyName (nameID=1).
If STAT table in the VF is a "dummy" (only has DesignAxes but no AxisValue records, like those fontmake generates to appease some browsers), then when creating static instances we need to drop STAT altogether. The fonttools instancer will keep it (it only drops AxisValues that falls outside the requested partial instance).

@m4rc1e m4rc1e reopened this Feb 26, 2021
@theolivenbaum
Copy link

@anthrotype could you by any chance upload the corrected Inter font files here till the issue is fixed upstream?

@theolivenbaum
Copy link

Nevermind, found the correct files in the Inter project repo!

@thlinard
Copy link
Contributor

Nobody is assigned to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants