From b6dcf9f4ddf4920272dcaf5ba70d03f391681e7e Mon Sep 17 00:00:00 2001 From: Ting-Yuan Huang Date: Fri, 30 Aug 2024 17:44:16 -0700 Subject: [PATCH] getJvmName: clean up (cherry picked from commit 1164ea67b6f3d27ac7e883b342301381e11d7de8) --- .../devtools/ksp/impl/ResolverAAImpl.kt | 27 ------------------- .../devtools/ksp/impl/symbol/kotlin/util.kt | 1 - 2 files changed, 28 deletions(-) diff --git a/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/ResolverAAImpl.kt b/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/ResolverAAImpl.kt index 8a3d11fd7c..17ae6120ca 100644 --- a/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/ResolverAAImpl.kt +++ b/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/ResolverAAImpl.kt @@ -60,14 +60,11 @@ import org.jetbrains.kotlin.analysis.low.level.api.fir.api.getFirResolveSession import org.jetbrains.kotlin.analysis.project.structure.KtSourceModule import org.jetbrains.kotlin.asJava.classes.KtLightClassForFacade import org.jetbrains.kotlin.asJava.findFacadeClass -import org.jetbrains.kotlin.asJava.toLightClass import org.jetbrains.kotlin.builtins.jvm.JavaToKotlinClassMap import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCliJavaFileManagerImpl import org.jetbrains.kotlin.fir.symbols.impl.FirCallableSymbol import org.jetbrains.kotlin.fir.types.isRaw import org.jetbrains.kotlin.fir.types.typeContext -import org.jetbrains.kotlin.light.classes.symbol.methods.SymbolLightAccessorMethod -import org.jetbrains.kotlin.light.classes.symbol.methods.SymbolLightSimpleMethod import org.jetbrains.kotlin.load.java.structure.impl.JavaClassImpl import org.jetbrains.kotlin.load.kotlin.JvmPackagePartSource import org.jetbrains.kotlin.load.kotlin.TypeMappingMode @@ -77,7 +74,6 @@ import org.jetbrains.kotlin.name.ClassId import org.jetbrains.kotlin.name.FqName import org.jetbrains.kotlin.name.FqNameUnsafe import org.jetbrains.kotlin.name.Name -import org.jetbrains.kotlin.psi.KtClassOrObject import org.jetbrains.kotlin.psi.KtFile import org.jetbrains.org.objectweb.asm.Opcodes @@ -487,21 +483,6 @@ class ResolverAAImpl( // TODO: handle library symbols override fun getJvmName(accessor: KSPropertyAccessor): String? { - ( - (accessor.receiver.closestClassDeclaration() as? KSClassDeclarationImpl) - ?.ktClassOrObjectSymbol?.psi as? KtClassOrObject - )?.toLightClass()?.allMethods - ?.let { - // If there are light accessors, information in light accessors are more accurate. - // check light accessor first, if not found then default to light simple method. - it.filterIsInstance() + it.filterIsInstance() - } - ?.firstOrNull { - (it.parameters.isNotEmpty() xor (accessor is KSPropertyGetter)) && - it.kotlinOrigin == (accessor.receiver as? KSPropertyDeclarationImpl)?.ktPropertySymbol?.psi - }?.let { - return it.name - } if (accessor.receiver.closestClassDeclaration()?.classKind == ClassKind.ANNOTATION_CLASS) { return accessor.receiver.simpleName.asString() } @@ -528,14 +509,6 @@ class ResolverAAImpl( // TODO: handle library symbols override fun getJvmName(declaration: KSFunctionDeclaration): String? { - (declaration.closestClassDeclaration() as? KSClassDeclarationImpl)?.ktDeclarationSymbol?.psi?.let { - (it as? KtClassOrObject)?.toLightClass() - }?.allMethods?.filterIsInstance()?.singleOrNull { - it.kotlinOrigin == (declaration as KSFunctionDeclarationImpl).ktFunctionSymbol.psi - }?.let { - return it.name - } - val symbol: KaFunctionSymbol? = when (declaration) { is KSFunctionDeclarationImpl -> declaration.ktFunctionSymbol else -> null diff --git a/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/util.kt b/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/util.kt index c6408ba337..6e6f18e846 100644 --- a/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/util.kt +++ b/kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/util.kt @@ -51,7 +51,6 @@ import org.jetbrains.kotlin.analysis.api.impl.base.types.KaBaseStarTypeProjectio import org.jetbrains.kotlin.analysis.api.impl.base.types.KaBaseTypeArgumentWithVariance import org.jetbrains.kotlin.analysis.api.platform.lifetime.KotlinAlwaysAccessibleLifetimeToken import org.jetbrains.kotlin.analysis.api.projectStructure.KaLibraryModule -import org.jetbrains.kotlin.analysis.api.projectStructure.KaLibrarySourceModule import org.jetbrains.kotlin.analysis.api.projectStructure.KaSourceModule import org.jetbrains.kotlin.analysis.api.symbols.* import org.jetbrains.kotlin.analysis.api.symbols.markers.KaDeclarationContainerSymbol