Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio: Initial integration #9480

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

silvergasp
Copy link
Contributor

Signed-off-by: Nathaniel Brough nathaniel.brough@gmail.com

@silvergasp
Copy link
Contributor Author

TODO: The git clone currently points to my fork of tokio. This should be switched back once tokio-rs/tokio#5392 is merged.

@silvergasp silvergasp force-pushed the tokio_initial_integration branch 2 times, most recently from 1f3a715 to ff14200 Compare January 22, 2023 21:27
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
We approve of adding this project.

@jonathanmetzman
Copy link
Contributor

let me know when this is ready for review.

@silvergasp
Copy link
Contributor Author

Will do! it's currently pointed at my fork, while I work through the kinks :)

Signed-off-by: Nathaniel Brough <nathaniel.brough@gmail.com>
@silvergasp silvergasp marked this pull request as ready for review February 9, 2023 19:17
@silvergasp
Copy link
Contributor Author

CC @Darksonn

Copy link

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -0,0 +1,11 @@
homepage: "https://tokio.rs/"
language: rust
primary_contact: aliceryhl@google.com
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record: This is me.

@jonathanmetzman jonathanmetzman merged commit 7192fb3 into google:master Feb 10, 2023
eamonnmcmanus pushed a commit to eamonnmcmanus/oss-fuzz that referenced this pull request Mar 15, 2023
Signed-off-by: Nathaniel Brough <nathaniel.brough@gmail.com>

Signed-off-by: Nathaniel Brough <nathaniel.brough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants