Support importing Protocol from typing_extensions.

In reality, Protocol is defined in typing_extensions. It's hard for us to move our definition from typing to typing_extensions because typing can't depend on any libraries except builtins, so instead import the class. Partially addresses #296. PiperOrigin-RevId: 244037223
google · Apr 17, 2019 · a9cf786 · a9cf786
1 parent 6aca77f
commit a9cf786
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 1 deletion.
diff --git a/pytype/CMakeLists.txt b/pytype/CMakeLists.txt
@@ -12,18 +12,21 @@ filegroup(
     pytd/builtins/2/mypy_extensions.pytd
     pytd/builtins/2/protocols.pytd
     pytd/builtins/2/typing.pytd
+    pytd/builtins/2/typing_extensions.pytd
 
     pytd/builtins/2and3/array.pytd
     pytd/builtins/2and3/mypy_extensions.pytd
     pytd/builtins/2and3/protocols.pytd
     pytd/builtins/2and3/typing.pytd
+    pytd/builtins/2and3/typing_extensions.pytd
 
     pytd/builtins/3/__builtin__.pytd
     pytd/builtins/3/array.pytd
     pytd/builtins/3/builtins.pytd
     pytd/builtins/3/mypy_extensions.pytd
     pytd/builtins/3/protocols.pytd
     pytd/builtins/3/typing.pytd
+    pytd/builtins/3/typing_extensions.pytd
 
     pytd/stdlib/2/_ctypes.pytd
     pytd/stdlib/2/collections.pytd

diff --git a/pytype/pytd/builtins/2/typing_extensions.pytd b/pytype/pytd/builtins/2/typing_extensions.pytd
@@ -0,0 +1,3 @@
+import typing
+Protocol = typing.Protocol
+def __getattr__(name) -> ?
diff --git a/pytype/pytd/builtins/2and3/typing_extensions.pytd b/pytype/pytd/builtins/2and3/typing_extensions.pytd
@@ -0,0 +1,3 @@
+import typing
+Protocol = typing.Protocol
+def __getattr__(name) -> ?
diff --git a/pytype/pytd/builtins/3/typing_extensions.pytd b/pytype/pytd/builtins/3/typing_extensions.pytd
@@ -0,0 +1,3 @@
+import typing
+Protocol = typing.Protocol
+def __getattr__(name) -> ?
diff --git a/pytype/tests/test_typing.py b/pytype/tests/test_typing.py
@@ -95,7 +95,7 @@ def test_generate_type_alias(self):
 
   def test_protocol(self):
     self.Check("""\
-      from typing import Protocol
+      from typing_extensions import Protocol
       class Foo(Protocol): pass
     """)