-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Info Notice (Storybook) #8137
Comments
AC ✔️ |
Thanks, @zutigrm. This is a good start but I think we need to improve IB a little bit. The main problem from my point of view is that IB tells us to implement everything within the InfoNotice component (btw you need to update the file name to be Let's introduce one more component |
Thanks @eugene-manuilov for the feedback
Oh indeed, good catch, thanks!
That's a good point. Although regarding |
This will add an extra responsibility to the parent component. Ideally, we should try to follow the single responsibility principle if we can. What if we use another name for that component? For example, instead of |
@eugene-manuilov That makes sense, thanks for the pointer. I will update IB to propose creation of |
Thanks, @zutigrm. IB looks better now, but after re-reading this task it seems that we don't need |
@eugene-manuilov Got it, IB updated |
Thanks, @zutigrm. IB 🌶️ |
QA Update ✅
|
Feature Description
Create the Info Notice widget component and add it to Storybook. It should display a static message, the full message sequence will be added separately via #8139.
See info notice in the design doc.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/js/modules/analytics-4/components/common/AudienceSegmentation/infoNotice.js
content
- Main text, it should be output withinp
tagdismissLabel
- A CTA labelonDismiss
- Optional callback that will be invoked when button is clickeddiv
with class, saygooglesitekit-audience-segmentation-info-notice
Button
component withtertiary
prop, and usedismissLabel
for button textonClick
should invoke a passedonDismiss
callback functionassets/sass/components/analytics-4/audience-segmentation/info-notice.scss
and apply styling to match the figma designTest Coverage
InfoNotice
component. Use the content from referenced figma design for the component in storiesQA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: