-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Audience Tile Error (Storybook) #8228
Labels
Module: Analytics
Google Analytics module related issues
P1
Medium priority
Team S
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
Comments
techanvil
added
Module: Analytics
Google Analytics module related issues
P1
Medium priority
Type: Enhancement
Improvement of an existing feature
labels
Feb 6, 2024
31 tasks
ivonac4
added
Next Up
Issues to prioritize for definition
and removed
Next Up
Issues to prioritize for definition
labels
Feb 9, 2024
Looks good to me 👍🏻 IB ✅ |
18 tasks
QA Update ❌Tested on Storybook Story. @benbowler In Figma text font family is 'Google Sans Text' and under Storybook implementation Font Family is 'Google Sans Display'. |
wpdarren
added
Good First Issue
Good first issue for new engineers
and removed
Good First Issue
Good first issue for new engineers
labels
Apr 15, 2024
18 tasks
QA Update ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Module: Analytics
Google Analytics module related issues
P1
Medium priority
Team S
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
Feature Description
Create the Audience Tile Error component and add it to Storybook.
See audience tiles > error states in the design doc.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Add a new component
/assets/js/modules/analytics-4/components/dashboard/AudienceSegmentation/AudienceTile/AudienceTileError.js
with the properrors
, an array of errors.hasInsufficientPermissionsError
, as implemented for widget errors:site-kit-wp/assets/js/components/ReportError.js
Lines 103 to 105 in 6f01a83
hasInsufficientPermissionsError
is true:https://sitekit.withgoogle.com/documentation/troubleshooting/analytics/#insufficient-permissions
serviceEntityAccessURL
, resolved using thegetServiceEntityAccessURL
selector:site-kit-wp/assets/js/components/ReportErrorActions.js
Lines 57 to 61 in 6f01a83
hasInsufficientPermissionsError
is false, render a single Retry button which, when clicked, calls a retryErrors function as implemented for widget errors:site-kit-wp/assets/js/components/ReportErrorActions.js
Lines 103 to 113 in 6f01a83
Add
assets/sass/components/analytics-4/audience-segmentation/_googlesitekit-audience-segmentation-tile-error.scss
and apply the styles to match the Figma designs in the AC.Test Coverage
AudienceTileError
tests and stories.QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: