Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the design of the Key Metrics setup CTA banner. #8895

Open
2 tasks
techanvil opened this issue Jun 18, 2024 · 4 comments
Open
2 tasks

Update the design of the Key Metrics setup CTA banner. #8895

techanvil opened this issue Jun 18, 2024 · 4 comments
Assignees
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature UX Issues that require UX input

Comments

@techanvil
Copy link
Collaborator

techanvil commented Jun 18, 2024

Feature Description

The current Key Metrics setup CTA banner looks like this:

Screenshot 2024-07-25 at 19 20 32

But the dismiss CTA is in the bottom of the banner, which isn’t consistent with our new banners.

We have a new Figma design for the Key Metrics setup CTA banner:

Screenshot 2024-07-25 at 19 17 18

This design should be applied to the banner in the plugin.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • Edit assets/js/components/KeyMetrics/KeyMetricsCTAContent.js and assets/js/components/KeyMetrics/KeyMetricsSetupCTAWidget.js
    • Adapt the markup for new design - swapping the CTA's, adding new text in the footer, replacing the SVG image with the one in figma, etc.
    • Note that mobile version has different SVG, which should be rendered conditionally based on the breakpoint , instead of the main one
    • New footer layout might need some tweaks in layout
  • Update assets/sass/components/key-metrics/_googlesitekit-key-metrics-setup-cta.scss
    • Adjust the styling to match new design - areas like font size, new footer section, position of the graphic, etc
  • Figma link in AC for desktop is opening the whole overview of the screens, so I am attaching the selected design link

Test Coverage

  • Update VRT's

QA Brief

  • Setup Site Kit with Analytics module
  • Verify that setup key metrics widget is showing as per new figma designs across the screens
  • Select 2 key metrics, then disconnect Analytics module
  • Verify that small connect GA4 CTA is showing correctly (there is no new design for this, it should look correctly across the screens)
  • Setup Analytics module and select 4 GA4 key metrics
  • Disconnect the module
  • Verify that big Analytics disconnected CTA is showing correctly across the screens - it follows same layout as default setup CTA just with different content, and footer CTA should be maybe later instead of select your own metrics

Changelog entry

@techanvil techanvil added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Jun 18, 2024
@tofumatt tofumatt self-assigned this Jul 23, 2024
@tofumatt tofumatt added the UX Issues that require UX input label Jul 23, 2024
@tofumatt
Copy link
Collaborator

As mentioned in Slack, this needs mobile designs/guidance before we can move it to IB, so leaving it in AC for now.

@tofumatt tofumatt removed their assignment Jul 25, 2024
@tofumatt
Copy link
Collaborator

Mobile designs are ready so moved this to IB 👍🏻

@binnieshah binnieshah added Team S Issues for Squad 1 Next Up Issues to prioritize for definition labels Jul 26, 2024
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Jul 26, 2024
@binnieshah binnieshah added Next Up Issues to prioritize for definition and removed Next Up Issues to prioritize for definition labels Jul 26, 2024
@eugene-manuilov eugene-manuilov self-assigned this Jul 26, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Jul 26, 2024
@zutigrm zutigrm self-assigned this Jul 29, 2024
@zutigrm zutigrm removed the Next Up Issues to prioritize for definition label Jul 30, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Jul 31, 2024

Parking it in the meantime until it gets a sprint number, since I picked it up by mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature UX Issues that require UX input
Projects
None yet
Development

No branches or pull requests

5 participants