Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAX application not loading correctly on the Ads setup screen. #9237

Closed
5 tasks
wpdarren opened this issue Aug 25, 2024 · 2 comments
Closed
5 tasks

PAX application not loading correctly on the Ads setup screen. #9237

wpdarren opened this issue Aug 25, 2024 · 2 comments
Labels
Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Bug Something isn't working

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Aug 25, 2024

Bug Description

An issue has occurred where the PAX app is not appearing within the iframe, and is now appearing underneath the WordPress footer. This means that users will not be able to create the ad campaign unless they scroll down the page.

pax

Steps to reproduce

  1. Set up.a site with the PAX pilot plugin (you can use the template in InstaWP)
  2. Go to Settings > Connect More Services and select the Ads module.
  3. Within the setup screen, click on the Create an account CTA
  4. Wait for 20-25 seconds, the app won't load in the iframe but scroll down and you wil see it displayed.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When using the PAX Pilot Plugin, or with the appropriate adsPax feature flag enabled, the PAX application should successfully render within the Ads Module setup container, not outside of it.

Implementation Brief

  • Update the versions of both the PAX integrator script and PAX SDK npm package to the latest versions, 1.0.12 at the time of writing:
    • Within includes/Modules/Ads.php:
      • Locate the pax integrator script URL, https://www.gstatic.com/pax/1.0.9/pax_integrator.js, and update it to be the latest 1.0.12 version: https://www.gstatic.com/pax/1.0.12/pax_integrator.js
    • Within package.json:
      • Locate the google-pax-sdk dependency entry, update it to match the integrator version, 1.0.12

Test Coverage

  • No tests needed for this fix.

QA Brief

  • Using either the PAX Pilot plugin or by enabling the adsPax feature flag:
    • Validate that PAX application loads within the Ads set up area
    • Validate that the PAX application and setup process works as intended from account creation to account ID storage within Site Kit
      • This can be validated by setting up Ads using PAX, and making sure the Ads conversion ID and account ID are stored within the Ads Settings area after completion

Changelog entry

  • Update the PAX library version.
@wpdarren wpdarren changed the title PAX application not loading correctly on the Site Kit setup page. PAX application not loading correctly on the Ads setup screen. Aug 25, 2024
@wpdarren wpdarren added Type: Bug Something isn't working Module: Ads Google Ads module related issues labels Aug 25, 2024
@tofumatt tofumatt self-assigned this Aug 28, 2024
@tofumatt
Copy link
Collaborator

tofumatt commented Aug 28, 2024

ACs are good and IB ✅

@tofumatt tofumatt assigned 10upsimon and unassigned tofumatt Aug 28, 2024
@binnieshah binnieshah added the Team S Issues for Squad 1 label Aug 28, 2024
@tofumatt tofumatt added the P0 High priority label Aug 28, 2024
@10upsimon 10upsimon removed their assignment Aug 28, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Aug 28, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Aug 30, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified issue is resolved and now PAX application loads within the Ads set up area.
  • Verified PAX application set up flow is working fine.
Recording.1355.mp4

@mohitwp mohitwp removed their assignment Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants