fix: improve stream detection logic

googleapis · Sep 6, 2019 · 6c41537 · 6c41537
1 parent 70f1217
commit 6c41537
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -81,6 +81,7 @@
     "abort-controller": "^3.0.0",
     "extend": "^3.0.2",
     "https-proxy-agent": "^2.2.1",
+    "is-stream": "^2.0.0",
     "node-fetch": "^2.3.0"
   }
 }
diff --git a/src/gaxios.ts b/src/gaxios.ts
@@ -16,6 +16,7 @@ import {Agent} from 'https';
 import nodeFetch, {Response as NodeFetchResponse} from 'node-fetch';
 import qs from 'querystring';
 import stream from 'stream';
+import isStream from 'is-stream';
 import url from 'url';
 
 import {
@@ -183,7 +184,7 @@ export class Gaxios {
 
     opts.headers = opts.headers || {};
     if (opts.data) {
-      if (this.isReadableStream(opts.data)) {
+      if (isStream.readable(opts.data)) {
         opts.body = opts.data;
       } else if (typeof opts.data === 'object') {
         opts.body = JSON.stringify(opts.data);
@@ -229,10 +230,6 @@ export class Gaxios {
     return qs.stringify(params);
   }
 
-  private isReadableStream(obj: any): boolean {
-    return obj instanceof stream.Readable && typeof obj._read === 'function';
-  }
-
   private translateResponse<T>(
     opts: GaxiosOptions,
     res: Response | NodeFetchResponse,