Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload GoogleCredentials.createScoped with variadic arguments #218

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Overload GoogleCredentials.createScoped with variadic arguments #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7612da
Add variadic overload of GoogleCredentials.createScoped
chingor13 Dec 19, 2018
bdf88d9
Remove unused import
chingor13 Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,17 @@ public GoogleCredentials createScoped(Collection<String> scopes) {
return this;
}

/**
* If the credentials support scopes, creates a copy of the the identity with the specified
* scopes; otherwise, returns the same instance.
*
* @param scopes Collection of scopes to request.
* @return GoogleCredentials with requested scopes.
*/
public GoogleCredentials createScoped(String... scopes) {
return createScoped(scopes);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this will just call itself, eventually resulting in a stack overflow.

Perhaps this should be:

return createScoped(ImmutableList.copyOf(scopes));

}

/**
* If the credentials support domain-wide delegation, creates a copy
* of the identity so that it impersonates the specified user;
Expand Down