Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating *OptionList and moving them to the internal namespace #10206

Closed
coryan opened this issue Nov 8, 2022 · 2 comments
Closed
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented Nov 8, 2022

I am not sure why things like this belong in the public namespace:

/// The complete list of options accepted by `bigtable::*Client`
using ClientOptionList =
OptionList<DataEndpointOption, AdminEndpointOption,
InstanceAdminEndpointOption, MinConnectionRefreshOption,
MaxConnectionRefreshOption>;

using DataPolicyOptionList =
OptionList<DataRetryPolicyOption, DataBackoffPolicyOption,
IdempotentMutationPolicyOption>;

@coryan coryan added the type: cleanup An internal cleanup or hygiene concern. label Nov 8, 2022
@coryan
Copy link
Contributor Author

coryan commented Nov 8, 2022

@dbolduc reminded me these are for discoverability. Being a "belt and suspenders" kind of person,I think we should expose these in the Doxygen documentation too.

@coryan
Copy link
Contributor Author

coryan commented Mar 29, 2023

We have improved the Doxygen pages to group options. Closing

@coryan coryan closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant