Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing ExperimentalTag for bidirectional streams #10307

Closed
dbolduc opened this issue Nov 28, 2022 · 0 comments · Fixed by #10340
Closed

Consider removing ExperimentalTag for bidirectional streams #10307

dbolduc opened this issue Nov 28, 2022 · 0 comments · Fixed by #10340
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@dbolduc
Copy link
Member

dbolduc commented Nov 28, 2022

The presence of the ExperimentalTag on read-write streams is leading to unnecessary confusion. (See #10285 / #10305).

We originally marked these APIs as experimental, because the interface is a bit tricky to use. Most of these bidirectional streams have service-specific behavior. (Googlers can see go/cloud-cxx:generated-bidir-rpcs).

We were hopeful that we could improve the API (maybe by offering hand-crafted APIs). We might not be able to. If we are able to, we can always do so by adding a new API (instead of replacing the old API). Having multiple ways to call the same thing may lead to some confusion, but I claim it is less confusion than the ExperimentalTags cause.

We should consider removing ExperimentalTag for bidirectional streams.

@dbolduc dbolduc added the type: cleanup An internal cleanup or hygiene concern. label Nov 28, 2022
@dbolduc dbolduc assigned dbolduc and unassigned dbolduc Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant