Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stall timeouts using watchdog timers #9558

Closed
3 tasks done
coryan opened this issue Jul 25, 2022 · 0 comments · Fixed by #9576
Closed
3 tasks done

Implement stall timeouts using watchdog timers #9558

coryan opened this issue Jul 25, 2022 · 0 comments · Fixed by #9576
Assignees
@coryan
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
GCS+gRPC: Public ...

Comments

@coryan
Copy link
Contributor

coryan commented Jul 25, 2022 •
edited
Loading

The current implementation using the asynchronous APIs. This moves the computation (e.g. decrypting the incoming data) to the I/O threads. This seems to bottleneck reads and writes.

Using a watchdog timer that cancels the stream on a timeout seems to perform better.

  • ReadObject()
  • InsertObject()
  • WriteObject()
@coryan coryan added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 25, 2022
@coryan coryan added this to the GCS+gRPC: Public Preview M3 milestone Jul 25, 2022
@coryan coryan self-assigned this Jul 25, 2022
This was referenced Jul 25, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
GCS+gRPC: Public Preview M3
Development

Successfully merging a pull request may close this issue.

feat(GCS+gRPC): more efficient WriteObject() stall timeouts coryan/google-cloud-cpp
1 participant
@coryan