Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack and install test fails #635

Closed
JustinBeckwith opened this issue May 31, 2019 · 2 comments · Fixed by #643
Closed

pack and install test fails #635

JustinBeckwith opened this issue May 31, 2019 · 2 comments · Fixed by #643
Assignees
@stephenplusplus
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. type: cleanup An internal cleanup or hygiene concern.

Comments

@JustinBeckwith
Copy link
Contributor

See #634
@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 31, 2019
@JustinBeckwith JustinBeckwith added type: cleanup An internal cleanup or hygiene concern. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 31, 2019
@stephenplusplus
Copy link
Contributor

Did you start seeing this with #634? Is the error always:

 1) 📦 pack and install
       should be able to use the d.ts:
     Error: Command failed: npm install --unsafe-perm
      at Promise.all.then.arr (node_modules/execa/index.js:231:11)
      at process._tickCallback (internal/process/next_tick.js:68:7)

Earlier in the build, there's also:

> tsc -p .
node_modules/p-queue/index.d.ts:81:54 - error TS2344: Type 'DefaultAddOptions' does not satisfy the constraint 'QueueAddOptions'.
  Index signature is missing in type 'DefaultAddOptions'.
81  EnqueueOptionsType extends PQueue.QueueAddOptions = PQueue.DefaultAddOptions
                                                        ~~~~~~~~~~~~~~~~~~~~~~~~

@callmehiphop
Copy link
Contributor

Looks like there's an open issue for this already sindresorhus/p-queue#66

@callmehiphop callmehiphop changed the title The system tests are flaky pack and install test fails Jun 6, 2019
@callmehiphop callmehiphop mentioned this issue Jun 7, 2019
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): update dependency p-queue to v6.0.2
3 participants
@JustinBeckwith @stephenplusplus @callmehiphop