From 625ecc503a6b193716820681aafe0f2daf16d4c4 Mon Sep 17 00:00:00 2001 From: Blake Li Date: Mon, 25 Sep 2023 11:12:17 -0400 Subject: [PATCH] fix: Add Geo common protos to Bazel test dependencies. (#2033) The generated unit tests for google/maps/places is not compilable, this is due to a Geo common proto is not added to Bazel test dependencies. See cl/567435528 and yaqs/8970072045605879808 for details. In long term, the Bazel Java test should be replaced with Maven/Gradle tests, so all the dependencies are managed through the gapic-generator-java jar instead of Bazel. This should be done as part of the Hermetic build project, cc: @JoeWang1127 --- rules_java_gapic/java_gapic.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/rules_java_gapic/java_gapic.bzl b/rules_java_gapic/java_gapic.bzl index a5bf043cca..f484c474d3 100644 --- a/rules_java_gapic/java_gapic.bzl +++ b/rules_java_gapic/java_gapic.bzl @@ -333,6 +333,7 @@ def java_gapic_library( # Test deps. actual_test_deps = [ "@com_google_googleapis//google/type:type_java_proto", # Commonly used. + "@com_google_googleapis//google/geo/type:viewport_java_proto", # Used by Geo. "@com_google_api_gax_java//gax:gax_testlib", "@com_google_code_gson_gson//jar", "@junit_junit//jar",