Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_zfs_zpool_state should have suspended as a state #1854

Closed
Hooloovoo opened this issue Jul 6, 2022 · 3 comments
Closed

node_zfs_zpool_state should have suspended as a state #1854

Hooloovoo opened this issue Jul 6, 2022 · 3 comments
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. stale Issue/PR mark as stale due lack of activity upstream An issue that must be fixed upstream

Comments

@Hooloovoo
Copy link

Hello,

It is great that the node_exporter in Grafana agent now collects node_zfs_zpool_state. It currently has:
unavail
degraded
faulted
offline
online
removed

I have a pool that is in the "SUSPENDED" state:
$ zpool status
pool: [pool name]
state: SUSPENDED
status: One or more devices are faulted in response to IO failures.
action: Make sure the affected devices are connected, then run 'zpool clear'.
see: http://zfsonlinux.org/msg/ZFS-8000-HC

and so none of the above statuses are triggered (thankfully I also monitor for online != 1). Could you please add this status as well?

@tpaschalis
Copy link
Member

Hey Aaron 👋

We're importing the upstream node_exporter code, where the ZFS pool states are defined here. The fastest way of handling this would be to open an issue or file a PR on the node_exporter repo and then update our dependency when the change is implemented.

There's no issue filed there, so I'm not sure if folks are aware of this status at all, would you mind creating one and linking it here so we can track its progress?

@Hooloovoo
Copy link
Author

Filed here: prometheus/node_exporter#2421

@rfratto rfratto added enhancement New feature or request upstream An issue that must be fixed upstream subsystem/integrations labels Jul 20, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 30 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label Aug 20, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2022
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. stale Issue/PR mark as stale due lack of activity upstream An issue that must be fixed upstream
Projects
None yet
Development

No branches or pull requests

3 participants