Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cluster_labels to centrally define more hard-coded strings #323

Open
4 tasks
darrenjaneczek opened this issue Jun 8, 2021 · 0 comments
Open
4 tasks

Comments

@darrenjaneczek
Copy link
Contributor

Related to the cluster_labels configuration value added in #319:

There are a few remaining instances of cluster_namespace and cluster, namespace in Recording Rules and Scaling which are not yet derived from the new configuration list cluster_labels. Only the Dashboards were updated to make use of the group_by_cluster and group_prefix_clusters strings which are generated from cluster_labels.

Acceptance criteria:

  • Recording rules and Scale are updated to make use of the centrally-overridable cluster_labels
    • Use group_prefix_clusters variable from $._group_config instead of hard-coded cluster_namespace
    • Use group_by_cluster variable from $._group_config instead of hard-coded cluster, namespace
  • Evaluate if it is appropriate to have other hard-coded strings that "start with" above two hard-coded string ('cluster_namespace_deployment', 'cluster, namespace, deployment', etc.) and update them accordingly

Question:

@pracucci , with the [cluster, namespace] list (cluster_labels) defining which labels identify a cluster, does it make sense to seek out references to cluster_namespace* string patterns and replace them with the corresponding prefix (group_prefix_clusters)?

Response:

I would start as smallest as possible because the potential replacement is huge. If this PR solves your use case, I would start from here and work on it on incremental PRs.
Originally posted by @pracucci in #319 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant