From 8d0ddfd2d35d460b56ce44cc2b09690c0abdff03 Mon Sep 17 00:00:00 2001 From: Mario Date: Thu, 14 Dec 2023 16:19:52 +0100 Subject: [PATCH] Make autocomplete filtering default to true (#3178) * Make autocomplete filtering default to true * chlog --- CHANGELOG.md | 1 + cmd/tempo/app/config.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 733f3c7a18c..dfcd0387784 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ * [CHANGE] TraceQL/Structural operators performance improvement. [#3088](https://github.com/grafana/tempo/pull/3088) (@joe-elliott) * [CHANGE] Merge the processors overrides set through runtime overrides and user-configurable overrides [#3125](https://github.com/grafana/tempo/pull/3125) (@kvrhdn) * [CHANGE] Make vParquet3 the default block encoding [#2526](https://github.com/grafana/tempo/pull/3134) (@stoewer) +* [CHANGE] Set `autocomplete_filtering_enabled` to `true` by default [#3178](https://github.com/grafana/tempo/pull/3178) (@mapno) * [CHANGE] Major cache refactor to allow multiple role based caches to be configured [#3166](https://github.com/grafana/tempo/pull/3166). **BREAKING CHANGE** Deprecate the following fields. These have all been migrated to a top level "cache:" field. ``` diff --git a/cmd/tempo/app/config.go b/cmd/tempo/app/config.go index 7e3daef73bd..7ab709cb03a 100644 --- a/cmd/tempo/app/config.go +++ b/cmd/tempo/app/config.go @@ -75,7 +75,7 @@ func (c *Config) RegisterFlagsAndApplyDefaults(prefix string, f *flag.FlagSet) { f.StringVar(&c.HTTPAPIPrefix, "http-api-prefix", "", "String prefix for all http api endpoints.") f.BoolVar(&c.UseOTelTracer, "use-otel-tracer", false, "Set to true to replace the OpenTracing tracer with the OpenTelemetry tracer") f.BoolVar(&c.EnableGoRuntimeMetrics, "enable-go-runtime-metrics", false, "Set to true to enable all Go runtime metrics") - f.BoolVar(&c.AutocompleteFilteringEnabled, "autocomplete-filtering.enabled", false, "Set to true to enable autocomplete filtering") + f.BoolVar(&c.AutocompleteFilteringEnabled, "autocomplete-filtering.enabled", true, "Set to false to disable autocomplete filtering") // Server settings flagext.DefaultValues(&c.Server)