Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from the azure-storage-blob-go SDK to the azure-sdk-for-go SDK #2835

Closed
LasseHels opened this issue Aug 23, 2023 · 1 comment · Fixed by #2882
Closed

Upgrade from the azure-storage-blob-go SDK to the azure-sdk-for-go SDK #2835

LasseHels opened this issue Aug 23, 2023 · 1 comment · Fixed by #2882

Comments

@LasseHels
Copy link
Contributor

LasseHels commented Aug 23, 2023

azure-storage-blob-go has been superseded by the azure-sdk-for-go, and is no longer being actively maintained.

Upgrading to azure-sdk-for-go is a prerequisite for at least one task (#2705), and will fix at least one bug (#2129):

@LasseHels
Copy link
Contributor Author

I'm actively working on this in a fork. Thus far, it seems like the API of the new SDK is pretty similar to the old, and I have not run into major issues. That said, I've not ran any E2E tests yet, so there may be problems waiting for me. I've updated functionality of the azure.readerWriter to use the new SDK, and am in the process of verifying that unit tests are still testing the correct behaviour, and passing when they should.

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/storage/azblob/migrationguide.md contains a brief overview of the major changes between the two SDKs.

I don't fully understand the different ways that Tempo can connect to Azure Blob Storage, and I am currently using azidentity.NewDefaultAzureCredential in the else authentication branch (i.e. the branch that doesn't use shared key credential). This is probably not what we want to do, and I'll revisit this when I have the rest of the functionality in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant