Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Expression.Return.get_value can be null #149

Merged
merged 2 commits into from
Apr 8, 2022
Merged

fix!: Expression.Return.get_value can be null #149

merged 2 commits into from
Apr 8, 2022

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Apr 8, 2022

Tested this locally with Grain.

@ospencer ospencer requested a review from phated April 8, 2022 02:56
@ospencer ospencer self-assigned this Apr 8, 2022
@ospencer ospencer mentioned this pull request Apr 8, 2022
Merged
phated
phated requested changes Apr 8, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test 🙏

@ospencer ospencer requested a review from phated April 8, 2022 14:16
phated
phated approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent!

@ospencer ospencer merged commit 559341d into master Apr 8, 2022
@ospencer ospencer deleted the oscar/fix-return-get-expr branch April 8, 2022 17:37
@github-actions github-actions bot mentioned this pull request Apr 8, 2022
Merged
@grainbot grainbot mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ospencer @phated