Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdPrestatGet contains a hack for null-terminated strings #1818

Open
ospencer opened this issue Apr 19, 2023 · 1 comment
Open

fdPrestatGet contains a hack for null-terminated strings #1818

ospencer opened this issue Apr 19, 2023 · 1 comment
Labels
WASI

Comments

@ospencer
Copy link
Member

Due to a bug in uvwasi, wasm runtimes that use it for their wasi implementations return a null-terminated string from fd_prestat_get, including the null terminator in the length. We have a hack that detects this and manually updates the length of the string. This should be removed when this is patched in uvwasi. See nodejs/uvwasi#202 for tracking.
@ospencer
Copy link
Member Author

The hack was introduced in #1585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WASI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ospencer @spotandjake