feat!: Remove js-runner #1585
feat!: Remove js-runner #1585
Conversation
ospencer
requested review from
phated,
peblair and
marcusroberts
as code owners
ospencer
force-pushed
the
oscar/remove-js-runner
branch
from
5d73d87
to
d658220
Compare
ospencer
force-pushed
the
oscar/remove-js-runner
branch
from
0cbe06c
to
f3203ec
Compare
|
Thanks to some investigation by @phated, we learned the two reasons the Windows tests are failing are because the process clock has only millisecond resolution (which is too imprecise for this test to pass) and the thread clock doesn't work. I sent nodejs/uvwasi#181 and nodejs/uvwasi#182 to address these. Hopefully they make it into Node 19, and we'll be able to ship this 😎 |
|
Given this will drop support for running in unlinked mode issue: #753 can probably be closed whenever this gets merged. |
cli/bin/exec.js
Outdated
| const doubleDash = process.argv.indexOf("--"); | ||
| const args = process.argv.slice(doubleDash + 1); |
There was a problem hiding this comment.
@ospencer Thoughts on doing this to pass the trailing argv to the WASI runner?
|
One question I've had since last night: How do we want to support env vars via the CLI? I think we can probably do the same thing as with preopens: |
|
That was my thinking exactly. |
Closes #645
Closes #1537
This PR removes the old js-runner. The recommended way to run Grain programs is via standard wasi-supporting tools!
Key points:
-pis no longer supported by the CLI, and--no-linkcan only be used withgrain compile(the cli no longer supports running unlinked programs).Tested and confirmed working with pkg.