fix(stdlib): Return early from Process.argv() if length is zero
#1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
requested review from
ospencer,
peblair,
marcusroberts and
jozanza
as code owners
ospencer
reviewed
Apr 18, 2023
| let arr = allocateArray(argc) | ||
|
|
||
| if (WasmI32.eqz(argsLength)) { | ||
| return Ok(WasmI32.toGrain(arr): Array<String>) |
There was a problem hiding this comment.
Suggested change
| return Ok(WasmI32.toGrain(arr): Array<String>) | |
| Memory.free(argcPtr) | |
| return Ok(WasmI32.toGrain(arr): Array<String>) |
could also refactor a bit to do the free after we read argc so we don't need to do it in multiple places.
There was a problem hiding this comment.
I tried to do the refactor. Let me know if it is correct!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns early from the
Process.argv()function if theargsLengthis zero. This avoids some differences between wasi implementations, and is also probably just a good idea to avoid extra sys calls.Fixes an issue I was encountering in #1585