Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler)!: Require module prefix on use/provide for modules #1868

Merged
merged 1 commit into from
Jul 1, 2023
Merged

feat(compiler)!: Require module prefix on use/provide for modules #1868

merged 1 commit into from
Jul 1, 2023

Conversation

alex-snezhko
Copy link
Member 

// provide
module Submodule {
  // ...
}
provide { module Submodule }

// use
from Mod use { module Submodule }

spotandjake
spotandjake approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alex-snezhko alex-snezhko force-pushed the include-provide-module-prefix branch from b8031d9 to dac52e5 Compare June 28, 2023 21:53
phated
phated approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🎉

@phated phated added this pull request to the merge queue Jul 1, 2023
Merged via the queue into grain-lang:main with commit 5efb54c Jul 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@spotandjake spotandjake spotandjake approved these changes

@ospencer ospencer Awaiting requested review from ospencer ospencer is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

Assignees

@alex-snezhko alex-snezhko

Labels
compiler
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-snezhko @phated @spotandjake