Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading docs for Java Primitives #105

Open
dan-f opened this issue May 3, 2023 · 4 comments
Open

Misleading docs for Java Primitives #105

dan-f opened this issue May 3, 2023 · 4 comments

Comments

@dan-f
Copy link

dan-f commented May 3, 2023

Describe the bug

I lost some time today debugging an issue where it seemed that the GraphQLBigDecimal scalar was not working. In fact, it turned out that the name of the scalar needed to be BigDecimal, not GraphQLBigDecimal.

The docs over here directly suggest that we should be naming these scalar GraphQLBigDecimal, which caused runtime errors for me.

To Reproduce

I reproduced this on the 19.1 release, but based on the current code, I'm assuming the bug is still present.

@dondonz
Copy link
Member

dondonz commented May 16, 2023

Hello! Thanks for taking the time to post this issue, it's highlighted that all the documentation (including the main graphql-java library) need a review and refresh, definitely don't want anyone wasting time because docs are out of date. As part of that work I'll look into your feedback.

@n614cd
Copy link

n614cd commented Jan 29, 2024

@dan-f

Thanks, finding this helped instead digging into the code.

@dondonz

Any chance you can update the docs?

@Jazornowsky
Copy link

Weird that such little thing still isn't fixed. I also wasted some time before I downloaded sources for autoconfiguration and it uses "BigDecimal" name instead of "GraphQLBigDecimal".

@janarthans
Copy link

Would be good if this is corrected in the documentation soon. Same applied for Long instead of GraphQLLong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants