Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving sand patterns #2831

Open
kocio-pl opened this issue Sep 14, 2017 · 2 comments
Open

Improving sand patterns #2831

kocio-pl opened this issue Sep 14, 2017 · 2 comments

Comments

@kocio-pl
Copy link
Collaborator

Related to #1990 and #2746.

  1. The main problem is that sand pattern (beach.png) is invisible for me at 100%, it just makes the natural=beach/sand area darker. The pattern become apparent at about 200%. However the pattern beach_coarse.png (used for gravel et co., but also for reef) looks already this way.

There may be few ways to correct it. We could just replace beach.png with current beach_coarse.png and then make one or more of the following:

  • enlarge also beach_coarse.png
  • use bigger elements for beach_coarse.png
  • use darker color for beach_coarse.png
  1. There's also smaller naming problem - beach.png should be rather more universal sand.png (as it's used for sand areas, but not for all the beach types) and beach_coarse.png might be renamed to a more universal name too (like coarse.png or gravel.png).

  2. Documentation could be improved by adding original options/links from pattern generator, if possible.

@kocio-pl kocio-pl added this to the Bugs and improvements milestone Sep 14, 2017
@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 12, 2019

@kocio-pl do you still think that the beach.png pattern is not clearly visible, except as making the surface appear darker? This would suggest removing it from natural=sand since sand has it's own fill color which can be adjusted darker or lighter.

(Note: I do not have a problem seeing the difference between beach without the pattern, beach.png and beach_coarse.png, they look like different patterns on the same color to me)

@kocio-pl
Copy link
Collaborator Author

I think this is way too fast to go into details of a single feature rendering when we're discussing more basic stuff.

You've already opened two sand-related PRs and just yesterday some structured proposition has appeared, that gives hope to make some clarity in all the rock/sand/beach mix - #3957 (comment) - which you have already commented 3 times (!) and we're waiting for a response to that... Adding even more discussion where more clarity is needed is counterproductive.

Please, hold on with that until we settle a system for what should be rendered with a color and/or overlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants