-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent way_area filters for water and landcover #4067
Comments
See also the discussion in #1566 |
How about the opposite, changing the landcover limit to 32 pixels at low zoom? Or compromising on 1 pixel for both The problem is that too many small features are dropped, especially with the limit at 32. This makes it look like well-mapped, finely-grained areas are blank, and would encourage mappers to create big multipolygons for forested areas, instead of mapping them in small, manageable pieces. z5: 0.01 pixel for both (landcover and water)z6: 0.01 pixelz7: 0.01 pixel |
@imagico, what is your preferred method to address the lower zoom levels? Previously you worked on the preprocessed shapefiles for water, which openstreetmap.de was using (but perhaps these are no longer available?) You also showed a custom renderer which uses a sort of supersampling technique to create low zoom level landcover/water rendering, for the alt-color low zoom demo. And openstreetmap.fr creates a large raster file at mid-zoom level, and then uses that for landcover/water areas at lower zoom levels. |
Note your rendering samples are of limited use for illustrating the problem because they already feature an infinite way_area threshold so to speak for most landcover types (which are not rendered at all). In Latvia also most non-wood landcover mapping is very spotty so it is not the best area to check this.
I have no strong preference here except the usual do something right or don't do it at all.
Yes, that was so far not ported to the new platform the fossgis data preprocessing runs on. And it has also essentially been superseded by the method that covers both water areas and landcover that i discussed in http://blog.imagico.de/on-basic-small-scale-landcover-rendering/. All of this requires more work to be turned into a practically well usable framework. But the overall interest in that is very small since most map producers either look for more sophisticated processing (which would be neither feasible nor desirable here due to mapper feedback function) or are firmly tied to the misguided wishful thinking for there to be a fee lunch (i.e. that you can solve the problem with trivial methods like way_area filtering). |
True, though at least it didn't matter that other landcover types were not shown, since Latvia didn't have much of them other than wood. I was mainly trying to show woods vs water, and Latvia was what I had on hand. Though it's true that considering residential areas and farmland would show the problem even more. Do you have a good example of a reasonable-sized extract (<100 mb .pbf) where landcover/landuse is nearly completely mapped?
Perhaps "if you build it, they will come?" Or is the problem that this is too big of a project to work on without a buyer in advance? As an alternative, the French style's solution seems to work fairly well right now, with the existing toolchain. We would just need osmdata to host a low-zoom landcover/water png or tiff which was updated based on a global water/landcover extract on at least a monthly basis, and add that to the list of data that needs to be downloaded, in addition to the water and ice shapefiles. |
Also see #4071 - right now we are showing the wetland pattern at z5 to z7 when the wetland area is only 1 pixel, so it's possible to have a tiny dark blue dot for a 1 or 2 pixel area wetland, while a nearby lake is not shown even though it would be 30 pixels in area. |
Expected behavior
Actual behavior
Solutions
Switch to pre-processed data for low-zoom landcover and water:
a) Raster image: for example, as done by the fr.openstreetmap.org style (using a large png raster file, which is generated with z10 data approximately)
b) Simplified polygons, like in the de.openstreetmap.org style (which used pre-processed data for water areas at z0 to z6, so that full data of water areas can be shown without performance problems - though this wasn't done for landcover yet)
Change the water limit to 0.01 pixels at low zoom again. This may slow down performance, but since these tiles are only rendered once a month or so, it may not be an issue for openstreetmap.org at least. But this will not solve the problem with landcover areas that consist of very small, detailed pieces, which will end up as less than 0.01 pixel at low zoom (z5 to z7 especially)
Stop showing inland water areas at low zoom (z4 and below) again. This would at least be consistent with landcover stopping at z5, and would acknowledge that the low-zoom rendering in this style has multiple issues which we can't easily fix without preprocessing. Some of the low-zoom issues cannot be fixed in this style, since they are inate to the Mercator projection at continent and global scales.
Links and screenshots illustrating the problem
The text was updated successfully, but these errors were encountered: