Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amd_gpu: better error message on device not found #2035

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

heitorPB
Copy link
Contributor

@heitorPB heitorPB commented Apr 4, 2024

Improve error message when supplied device is non existent.

Fix #2034

Improve error message when supplied device is non existent.

Fix greshake#2034
@heitorPB
Copy link
Contributor Author

heitorPB commented Apr 4, 2024

How would I add a test for existing devices?

@MaxVerevkin
Copy link
Collaborator

No need to add tests, IMO. Just keep the one you added.

Copy link
Collaborator

@MaxVerevkin MaxVerevkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MaxVerevkin MaxVerevkin merged commit 5de8e03 into greshake:master Apr 4, 2024
13 checks passed
@heitorPB heitorPB deleted the amd-gpu-error-message branch April 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amd_gpu: improve the error when a device does not exist
2 participants