Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete condition checks in ConnectBlock #1316

Closed
denravonska opened this issue Oct 8, 2018 · 2 comments
Closed

Remove obsolete condition checks in ConnectBlock #1316

denravonska opened this issue Oct 8, 2018 · 2 comments
Milestone

Comments

@denravonska
Copy link
Member

ConnectBlock has a couple of checks which were added during a transition phase. These conditions can no longer evaluate to true.

if (IsResearcher(bb.cpid) && IsLockTimeWithinMinutes(GetBlockTime(), GetAdjustedTime(), 15) && !IsResearchAgeEnabled(pindex->nHeight))

Can no longer happen due to grandfather being beyond the research age start.

if (IsProofOfWork() && pindex->nHeight > nGrandfather)

PoW blocks stopped at block 2050. Further PoW blocks are rejected in AcceptBlock.

@denravonska denravonska added this to the Camilla milestone Oct 8, 2018
@denravonska
Copy link
Member Author

Same issues as #1174.

@denravonska denravonska modified the milestones: Camilla, Denise Jan 15, 2019
@jamescowens jamescowens modified the milestones: Denise, Elizabeth Mar 30, 2019
@denravonska denravonska modified the milestones: Elizabeth, Fern Jul 8, 2019
@jamescowens jamescowens modified the milestones: Fern, Gladys Aug 3, 2019
@jamescowens
Copy link
Member

Done by #1572.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants