Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate upstream Encode and Decode Base 58 optimizations #2300

Closed
barton2526 opened this issue Aug 25, 2021 · 1 comment · Fixed by #2384
Closed

Investigate upstream Encode and Decode Base 58 optimizations #2300

barton2526 opened this issue Aug 25, 2021 · 1 comment · Fixed by #2384
Labels
enhancement
Milestone
Janice

Comments

@barton2526
Copy link
Member

Upstream PRs:

This change consists in avoiding filling the b58 buffer with zeros. The improvement is about 30% - 45%.

For example, calling listunspents with my wallet results in 313ms in EncodeBase58 whereas before was 578ms.

Improve DecodeBase58 performance the same way as commit 3252208 did
for EncodeBase58.
...
That's about 32% decrease for the average time.
@jamescowens
Copy link
Member

I think we should implement this.

@jamescowens jamescowens added this to the Janice milestone Aug 29, 2021
@jamescowens jamescowens mentioned this issue Nov 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Janice
2 participants
@jamescowens @barton2526