Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetArg should explicitly be case insensitive #294

Closed
denravonska opened this issue May 4, 2017 · 1 comment
Closed

GetArg should explicitly be case insensitive #294

denravonska opened this issue May 4, 2017 · 1 comment
Assignees
Milestone

Comments

@denravonska
Copy link
Member

denravonska commented May 4, 2017

It's currently not clear whether arguments are case insensitive or not, see ambiguity when storing and reading the config file. This is possibly an issue when checking if the current private and public keys are valid, see https://github.com/gridcoin/Gridcoin-Research/blob/master/src/rpcblockchain.cpp#L1319.

Improvements:

  • See if we can use boost::program_options for writing config values.
  • Use case insensitivity in GetArg.
  • Try to unit test this.
  • Move the many config file and argument handling functions to an args.cpp/h.

Thanks to @Foggyx420 for noticing.

denravonska referenced this issue in iFoggz/Gridcoin-Research May 30, 2017
@denravonska denravonska added this to the Unnamed milestone Aug 25, 2017
@iFoggz
Copy link
Member

iFoggz commented Sep 9, 2017

has this generally been addresses since the beacon advertising issues are fixed.?

if not we coudl boost:to_lower but some keys like 'PrimaryCPID' and UpdatingLeaderBoard would be affected?

@denravonska denravonska self-assigned this Jun 3, 2018
@iFoggz iFoggz mentioned this issue Aug 9, 2018
denravonska added a commit that referenced this issue Apr 3, 2019
Added:
 - Add `rainbymagnitude` RPC command #1235 (@Foggyx420).
 - Add stake splitting and side staking #1265 (@jamescowens).
 - Detect and block Windows shutdown so wallet can exit cleanly #1309
   (@jamescowens).
 - Add message support to sendfrom and sendtoaddress #1400 (@denravonska).

Changed:
 - Configuration options are now case insensitive #294 (@Foggyx420).
 - Update command in beaconstatus help message #1312 (@chrstphrchvz).
 - Improve synchronization speeds:
   - Refactor superblock pack/unpack #1194 (@denravonska).
   - Optimize neuralsecurity calculations #1255 (@denravonska).
   - Reduce hash calculations when checking blocks #1206 (@denravonska).
 - Make display of private key in beaconstatus OPT-IN only #1275 (@Foggyx420).
 - Store Beacon keys in Wallet #1088 (@tomasbrod).
 - Use default colors for pie chart #1333 (@chrstphrchvz).
 - Show hand cursor when hovering clickable labels #1332 (@chrstphrchvz).
 - Update README.md #1337 (@Peppernrino).
 - Fix integer overflow with displayed nonce #1297 (@personthingman2).
 - Improve application cache performance #1317 (@denravonska).
 - Improve reorg speeds #1263 (@denravonska).
 - Update Polish translation #1375 (@michalkania).

Fixed:
 - Remove expired polls from overview page #1250 (@personthingman2).
 - Fix plural text on block age #1304 (@scribblemaniac).
 - Fix researcher staking issue if your chain head was staked by you,
   #1299 (@denravonska).
 - Fix incorrect address to grcpool node #1314 (@wilkart).
 - Do not replace underscores by spaces in Qt Poll URLs #1327 (@tomasbrod).
 - Fix scraper SSL issues #1330 (@Foggyx420).

Removed:
 - Remove or merged several RPC commands #1228 (@Foggyx420):
    - `newburnaddress`, removed.
    - `burn2`: Removed.
    - `cpid`: Merged into `projects`.
    - `mymagnitude`: Merged into `magnitude`.
    - `rsa`: Removed, use `magnitude`.
    - `rsaweight`: Removed, use `magnitude`.
    - `proveownership`: Removed.
    - `encrypt`: Removed.
 - Remove obsolete POW fields from RPC responses #1358 (@jamescowens).
 - Remove obsolete netsoft fields for slight RAM requirement reduction
   #1336 (@denravonska).
 - Remove unused attachment functionality #1345 (@denravonska).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants