Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing RSAWeight and StructCPID::ResearchSubsidy #919

Closed
denravonska opened this issue Feb 4, 2018 · 3 comments
Closed

Consider removing RSAWeight and StructCPID::ResearchSubsidy #919

denravonska opened this issue Feb 4, 2018 · 3 comments

Comments

@denravonska
Copy link
Member

denravonska commented Feb 4, 2018

It looks like some of the forking is due to StructCPID::ResearchSubsidy not being adjusted when disconnecting blocks. We could add adjustments to that for each but I can't find any traces that we actually use these values for anything anymore, so we can consider removing them.

They were used to trigger newbie weight boost in pre-v8 blocks but that is long gone. See wallet.cpp:1750.

Edit: This will be a V10 thing so we'll have to settle for backtracking when disconnecting.

@tomasbrod
Copy link
Member

tomasbrod commented Feb 4, 2018

@denravonska Are you certain that StructCPID::ResearchSubsidy is really not used anywhere in acceptance chain for blocks of current version (ignore the pre v8).
I do not think otherwise, but I do not know and want to have reliable info.

@denravonska
Copy link
Member Author

denravonska commented Feb 4, 2018

@tomasbrod Looked further and added the V10 comment earlier. The check is used in ComputeResearchAccrual called by GetProofOfStakeReward, so it is used in the acceptance chain.

Will post a separate report regarding PPD being out of sync with the net. See #920.

@jamescowens
Copy link
Member

I think all of this is addressed in #1583.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants