getblockstats rpc call bug #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
division by zero is undefined behaviour and the end result was this |
|
Floating point division by zero IS defined by IEEE 754. The problem is handling of NaN, +inf and -inf surreal numbers. |
denravonska
reviewed
Sep 9, 2018
src/rpcdataacq.cpp
Outdated
| if (super_count > 0) | ||
| result.pushKV("super_spacing_hrs", (((double)l_last_time-(double)l_first_time)/(double)super_count)/3600.0); | ||
| else | ||
| result.pushKV("super_spacing_hrs", "N/A"); |
There was a problem hiding this comment.
I think we should strive for not including "null" values in the JSON output, see https://google.github.io/styleguide/jsoncstyleguide.xml#Empty/Null_Property_Values
tomasbrod
approved these changes
Sep 9, 2018
…d fail to handle a null float
denravonska
force-pushed
the
dividebyzerobug
branch
from
7053eda
to
a18af8a
Compare
denravonska
added a commit
that referenced
this pull request
Oct 19, 2018
Added: - Linux nodes can now stake superblocks using forwarded contracts #1060 (@tomasbrod). Changed: - Replace interest with constant block reward #1160 (@tomasbrod). Fork is set to trigger at block 1420000. - Raise coinstake output count limit to 8 #1261 (@tomasbrod). - Port of Bitcoin hash implementation #1208 (@jamescowens). - Minor canges for the build documentation #1091 (@Lenni). - Allow sendmany to be used without an account specified #1158 (@Foggyx420). Fixed: - Fix `cpids` and `validcpids` not returning the correct data #1233 (@Foggyx420). - Fix `listsinceblock` not showing mined blocks to change addresses #501 (@Foggyx420). - Fix crash when raining using a locked wallet #1236 (@Foggyx420). - Fix invalid stake reward/fee calculation (@jamescowens). - Fix divide by zero bug in `getblockstats` RPC #1292 (@Foggyx420). - Bypass historical bad blocks on testnet #1252 (@Quezacoatl1). - Fix MacOS memorybarrier warnings #1193 (@ghost). Removed: - Remove neuralhash from the getpeerinfo and node stats #1123 (@Foggyx420). - Remove obsolete NN code #1121 (@Foggyx420). - Remove (lower) Mint Limiter #1212 (@tomasbrod).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the rpc call of getblockstats.
essentially what was happening was the univalue handles differently between ui and command line call/http call
The problem was the division by 0 when the super_count was 0 resulting in a result leaving an empty result in json reply. essentially when univalue tried to process the read on it the json was invalid.
as you can see
super_spacing_hrs