consensus: Implement 1E-8 relative tolerance in CheckReward() #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Fern code goes to great lengths to remove sources of rounding error from the research rewards accrual, some double math remains, and can in certain circumstances generate a very small amount of error in the calculations of the rewards between the staking machine and the calculating machine. This commit allows the claimed reward to exceed the computed award at a rate of 1 Halford per 1 GRC of the total computed award, which is a relative error of 1E-8.
|
@cyrossignol and I have agreed to try and solve the problem by changing the offending code to integer math. I will retain this open until we prove that solution works, because we may end up have to use this. |
|
This was solved a different way in #1799 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Fern code goes to great lengths to remove sources of rounding error from the research rewards accrual, some double math remains, and can in certain circumstances generate a very small amount of error in the calculations of the rewards between the staking machine and the calculating machine. This commit allows the claimed reward to exceed the computed award at a rate of 1 Halford per 1 GRC of the total computed award, which is a relative error of 1E-8. This is an extremely tight tolerance, but should be enough to avoid any rounding errors that could affect concensus, and is vastly superior to the old 25% + 1 GRC slop allowed in the pre-v11 code.