Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix advanced compiler warnings #2292

Merged
merged 27 commits into from
Sep 10, 2021
Merged

refactor: Fix advanced compiler warnings #2292

merged 27 commits into from
Sep 10, 2021

Commits on Sep 4, 2021

  1. Change class ConvergedScraperStats to struct in superblock.h 

    Silences tag mismatch warning.
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    e590d91 View commit details
    Browse the repository at this point in the history

  2. Rewrite GMF_RELAY check to silence duplicate branch compile warning 

    Co-authored-by: RoboticMind <30132912+RoboticMind@users.noreply.github.com>
    @jamescowens @RoboticMind
    jamescowens and RoboticMind committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    37d022d View commit details
    Browse the repository at this point in the history

  3. Change class ConvergedScraperStats to struct in clientmodel.h 

    Silences conflicting tag warning.
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    77a57b5 View commit details
    Browse the repository at this point in the history

  4. Initialize nSize in script.h 

    Silences possible use of uninitialized variable warning.
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    e692033 View commit details
    Browse the repository at this point in the history

  5. Adjust prevector.h to eliminate anonymous struct 

    Cf. Bitcoin PR 18088
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    fd7f557 View commit details
    Browse the repository at this point in the history

  6. Add boost::placeholders qualifier to boost bind placeholders

    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    1d745fe View commit details
    Browse the repository at this point in the history

  7. Add static_cast<size_t> to eliminate overflow warning on 32 bit platf… 

    …orms
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    783dd1e View commit details
    Browse the repository at this point in the history

  8. Change include from <boost/bind.hpp> to <boost/bind/bind.hpp>

    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    680a7cc View commit details
    Browse the repository at this point in the history

  9. Update prevector.h with upstream changes

    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    3e8b8c0 View commit details
    Browse the repository at this point in the history

  10. Remove -Werror=gnu checks 

    We are not concerned about using gnu extensions such as zero argument
variadics.
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    143ac32 View commit details
    Browse the repository at this point in the history

  11. Cast SCALE_FACTOR to int64_t to fix signed vs unsigned comparison war… 

    …ning
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    9b067ae View commit details
    Browse the repository at this point in the history

  12. Update CCryptoKeyStore::Unlock 

    This commit updates the above function to properly traverse the
mapCryptedKeys and eliminates the Clang loop will run at most once
warning.
    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    23b1bd0 View commit details
    Browse the repository at this point in the history

  13. Add thread-safety qualifiers and correct some minor issues found

    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    1641123 View commit details
    Browse the repository at this point in the history

  14. Port more of Bitcoin's sync.h/cpp to fix debug locking

    @jamescowens
    jamescowens committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    1229f27 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Adjust sync.cpp to allow continued operation with potential deadlock

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    594658b View commit details
    Browse the repository at this point in the history

  2. Implement thread_local where available

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    b6b596b View commit details
    Browse the repository at this point in the history

  3. Implement Bitcoin style internal thread naming for thread_local

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    31f7862 View commit details
    Browse the repository at this point in the history

  4. Change iterator in listpolls to reference type

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    83dcef2 View commit details
    Browse the repository at this point in the history

  5. Fix unsigned compared to signed warning in magnitude_tests.cpp

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    ec05f93 View commit details
    Browse the repository at this point in the history

  6. Fix unsigned and signed comparison warning in beacon_tests.cpp

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    03bd4cd View commit details
    Browse the repository at this point in the history

  7. Fix unsigned vs signed comparison warning in superblock_tests.cpp

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    54169d1 View commit details
    Browse the repository at this point in the history

  8. Fix unsigned vs signed comparison warning in multisig_tests.cpp

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    29d3923 View commit details
    Browse the repository at this point in the history

  9. fix unsigned vs signed comparison warning in script_p2sh_tests.cpp

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    588bd2b View commit details
    Browse the repository at this point in the history

  10. Fix unsigned vs signed comparison warning in sigopcount_tests.cpp

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c20695e View commit details
    Browse the repository at this point in the history

  11. Fix unsigned vs signed comparison warning in wallet_tests.cpp

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    a7fc110 View commit details
    Browse the repository at this point in the history

  12. Change iterator to reference tye in VotingModel constructor

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    f682227 View commit details
    Browse the repository at this point in the history

  13. Change iterator to reference type in buildPollTable

    @jamescowens
    jamescowens committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    a3289ff View commit details
    Browse the repository at this point in the history