Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc, util, consensus: Implement exception handling framework for MRC and fix ValidateMRC to deal with testnet consensus issue #2508

Merged
merged 4 commits into from
May 7, 2022
Merged

rpc, util, consensus: Implement exception handling framework for MRC and fix ValidateMRC to deal with testnet consensus issue #2508

merged 4 commits into from
May 7, 2022

Commits on May 6, 2022

  1. Implement exception handling framework for MRC 

    This implements a simple exception handling class for MRC that
is an extension of std::runtime_error. It is similar to the bignum_error class.

The MRC_error initializer issues a LogPrintf to the log with the error, so the
throwing function does not have to worry about logging the error separately.

We can get much fancier later, and we need to implement a rigorous exception
handling framework across the board IMHO, but this is good enough for the
intended purpose here, which is to provide more detailed error feedback to
createmrcrequest.
    @jamescowens
    jamescowens committed May 6, 2022
    Configuration menu
    Copy the full SHA
    ecc4b11 View commit details
    Browse the repository at this point in the history

  2. Correct reward and fee initialization in mrc_tests.cpp

    @jamescowens
    jamescowens committed May 6, 2022
    Configuration menu
    Copy the full SHA
    795147d View commit details
    Browse the repository at this point in the history

  3. Add hash to tx index not found

    @jamescowens
    jamescowens committed May 6, 2022
    Configuration menu
    Copy the full SHA
    603bac0 View commit details
    Browse the repository at this point in the history

  4. Implement modified MRC transaction rejection in ValidateMRC for testnet 

    This deals with post v12 mandatory MRCs in testnet that passed originally
but failed after a change to use MRC time rather than tx time.
    @jamescowens
    jamescowens committed May 6, 2022
    Configuration menu
    Copy the full SHA
    1b0c91d View commit details
    Browse the repository at this point in the history