Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: Add init error message if -printtoconsole and -daemon specified simultaneously #2571

Merged
merged 1 commit into from
Sep 5, 2022
Merged

init: Add init error message if -printtoconsole and -daemon specified simultaneously #2571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/gridcoinresearchd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,16 @@ bool AppInit(int argc, char* argv[])
return !CommandLineRPC(argc, argv);
}

if (gArgs.GetBoolArg("-printtoconsole", false) && gArgs.GetBoolArg("-daemon", DEFAULT_DAEMON)) {
return InitError("-printtoconsole && -daemon cannot be specified at the same time,\n"
"because Gridcoin follows proper daemonization and disconnects the\n"
"console when the process is forked. This is consistent with Bitcoin\n"
"Core. Please see https://github.com/bitcoin/bitcoin/issues/10132.\n"
"If you are not specifying -daemon as a startup parameter, but only\n"
"-printtoconsole, and you are geting this error, please check the\n"
"gridcoinresearch.conf and comment out daemon=1, or use -nodaemon.");
}

// -server defaults to true for gridcoinresearchd but not for the GUI so do this here
gArgs.SoftSetBoolArg("-server", true);
// Initialize logging as early as possible.
Expand Down
9 changes: 7 additions & 2 deletions src/init.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,13 @@ void SetupServerArgs()
ArgsManager::ALLOW_ANY, OptionsCategory::RPC);

#if HAVE_DECL_FORK
argsman.AddArg("-daemon", strprintf("Run in the background as a daemon and accept commands (default: %d)", DEFAULT_DAEMON), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
argsman.AddArg("-daemonwait", strprintf("Wait for initialization to be finished before exiting. This implies -daemon (default: %d)", DEFAULT_DAEMONWAIT), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
argsman.AddArg("-daemon",
strprintf("Run in the background as a daemon and accept commands (default: %d)", DEFAULT_DAEMON),
ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
argsman.AddArg("-daemonwait",
strprintf("Wait for initialization to be finished before exiting. "
"This implies -daemon (default: %d)", DEFAULT_DAEMONWAIT),
ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
#else
hidden_args.emplace_back("-daemon");
hidden_args.emplace_back("-daemonwait");
Expand Down