gui: Add one minute QTimer to update beacon age/expiration in tooltip

[jamescowens]

This adds a trivial QTimer with a frequency of once per minute to update the beacon status in the GUI, and ensure the tooltip accurately reflects beacon age and time remaining until expiration.

[barton2526]

Is one minute really what we want? It seems a little too frequent IMO.

[jamescowens]

It is a trivial update, and since we display the expiration times down to the second, even a minute is arguably not frequent enough. I think one minute is a good compromise.

The function being called does very little work...

void BitcoinGUI::updateBeaconIcon()
{
    LogPrint(BCLog::MISC, "BitcoinGUI::updateBeaconIcon()");

    if (researcherModel->configuredForInvestorMode()
        || researcherModel->detectedPoolMode())
    {
        labelBeaconIcon->hide();
        return;
    }

    labelBeaconIcon->show();
    labelBeaconIcon->setPixmap(GRC::ScaleStatusIcon(this, researcherModel->getBeaconStatusIcon()));

    if (researcherModel->hasPendingBeacon()) {
        labelBeaconIcon->setToolTip(tr("CPID: %1\n"
                                       "Time left to activate: %2"
                                       "%3")
                                    .arg(researcherModel->formatCpid(),
                                         researcherModel->formatTimeToPendingBeaconExpiration(),
                                         researcherModel->formatBeaconStatus()));
    } else if (researcherModel->beaconExpired()) {
        labelBeaconIcon->setToolTip(tr("CPID: %1\n"
                                       "Beacon age: %2\n"
                                       "Current beacon expired!\n"
                                       "%3")
                                    .arg(researcherModel->formatCpid(),
                                         researcherModel->formatBeaconAge(),
                                         researcherModel->formatBeaconStatus()));
    } else if (researcherModel->hasActiveBeacon()) {
        labelBeaconIcon->setToolTip(tr("CPID: %1\n"
                                       "Beacon age: %2\n"
                                       "Expires: %3\n"
                                       "%4")
                                    .arg(researcherModel->formatCpid(),
                                         researcherModel->formatBeaconAge(),
                                         researcherModel->formatTimeToBeaconExpiration(),
                                         researcherModel->formatBeaconStatus()));
    } else {
        labelBeaconIcon->setToolTip(researcherModel->formatBeaconStatus());
    }
}

[barton2526]

Why do we display down to the second in the first place? Maybe we should just display down to the minute and update every minute.

[jamescowens]

I agree with you but that is a more extensive change that I would rather do against the dev branch. This is against hotfix and is going to be put into a point release with the other hotfixes merged since the 5.4.2.0 release.

[barton2526]

utACK