From b6347ff8cba2eae2bdf2015e06ac58c7889abbec Mon Sep 17 00:00:00 2001 From: "Artem V. Navrotskiy" Date: Thu, 25 Jan 2024 09:52:43 +0300 Subject: [PATCH] Fix `InitializeMetrics` signature to allow use with `xds.GRPCServer` --- providers/prometheus/server_metrics.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/providers/prometheus/server_metrics.go b/providers/prometheus/server_metrics.go index 9b2f3e6d8..def21e5bf 100644 --- a/providers/prometheus/server_metrics.go +++ b/providers/prometheus/server_metrics.go @@ -7,6 +7,7 @@ import ( "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors" "github.com/prometheus/client_golang/prometheus" "google.golang.org/grpc" + "google.golang.org/grpc/reflection" ) // ServerMetrics represents a collection of metrics to be registered on a @@ -81,7 +82,7 @@ func (m *ServerMetrics) Collect(ch chan<- prometheus.Metric) { // value, for all gRPC methods registered on a gRPC server. This is useful, to // ensure that all metrics exist when collecting and querying. // NOTE: This might add significant cardinality and might not be needed in future version of Prometheus (created timestamp). -func (m *ServerMetrics) InitializeMetrics(server *grpc.Server) { +func (m *ServerMetrics) InitializeMetrics(server reflection.ServiceInfoProvider) { serviceInfo := server.GetServiceInfo() for serviceName, info := range serviceInfo { for _, mInfo := range info.Methods {