New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix structured log identifiers on client and server #585

Closed

JamesNK opened this issue Oct 5, 2019 · 0 comments · Fixed by #589

Assignees

Labels

bug

Milestone

Member

JamesNK commented Oct 5, 2019

I didn't under how structured log identifiers worked, and we have some duplicates. A log message ID should be unique for a named logger.

Also, start ID at 1 instead of 0 (0 is for unstructured messages)

JamesNK added the bug label

JamesNK added this to the vNext milestone

JamesNK self-assigned this

JamesNK mentioned this issue

Fix duplicate log IDs #589

Merged

JamesNK closed this as completed in #589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment